Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to configure the scope #3

Closed
RKrahl opened this issue Feb 2, 2017 · 8 comments · Fixed by #35
Closed

Add a way to configure the scope #3

RKrahl opened this issue Feb 2, 2017 · 8 comments · Fixed by #35
Labels
enhancement New feature or request
Milestone

Comments

@RKrahl
Copy link
Owner

RKrahl commented Feb 2, 2017

For the moment, the scope of the dependencies is hard coded to module. That means that a test can only be marked as dependent on a test in the same module, but cannot depend on a test in a different module. The backend class DependencyManager is in principle also capable to work on session scope. But the calling hooks do not use the optional scope argument in the getManager() call.

The difficulty is that I have no idea how to define a clean API to configure the scope from the calling tests.

@RKrahl RKrahl added the enhancement New feature or request label Feb 2, 2017
@JoeSc
Copy link
Contributor

JoeSc commented Feb 23, 2018

Take a look at
JoeSc@d282e6d

I think it does what you want, and is sane. All the existing tests still pass.
Let me know if you approve or want changes and I can add some documentation

@Formartha
Copy link

I am waiting for this to be merged in as well :)

@babaMar
Copy link

babaMar commented Jul 6, 2018

Me too 👍

@CMCDragonkai
Copy link

@JoeSc can we create a PR based on your changes?

@bentsi
Copy link

bentsi commented Jan 15, 2019

+1

@MathReynaud
Copy link

MathReynaud commented Apr 15, 2019

This will be useful in our case too !

@juicedatom
Copy link

I'm all up for this as well!

@fbarbu15
Copy link

Waiting for this as well! Thanks

@RKrahl RKrahl added this to the 0.5 milestone Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
9 participants