Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion per document or for the whole workspace #58

Closed
renkun-ken opened this issue Sep 18, 2019 · 2 comments
Closed

Autocompletion per document or for the whole workspace #58

renkun-ken opened this issue Sep 18, 2019 · 2 comments

Comments

@renkun-ken
Copy link
Member

The current implementation of symbol provider is workspace-wide, i.e., if you open and edit 10 R script files, then all documents are parsed and all symbols are shared in the completion list when I edit one file.

This can sometimes be annoying if I need to edit a simple script and a very long script that defines a lot of symbols at the same time.

I'm wondering if it makes sense to provide symbols per document, or according to referenced documents (as mentioned in #20).

@randy3k
Copy link
Member

randy3k commented Sep 18, 2019

I guess we will need to check if the files are coming from the same package. Files from the same package should share the symbol completions. We may need to open a workspace for each independent file.

@renkun-ken
Copy link
Member Author

Global namespace no longer infinitely grows with #123 merged. So the behavior is good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants