Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float / Double matchers should use FloatingPoint protocol #394

Closed
jeffh opened this issue Jan 31, 2017 · 1 comment · Fixed by #879
Closed

Float / Double matchers should use FloatingPoint protocol #394

jeffh opened this issue Jan 31, 2017 · 1 comment · Fixed by #879
Assignees

Comments

@jeffh
Copy link
Member

jeffh commented Jan 31, 2017

Since Swift has simplified the crazy protocol change for numerics, Nimble should switch to use the new protocol instead of simplifying it down to Double types.

beCloseTo matcher is the obvious one that needs fixing, but others that explicitly use Double should be updated as needed.

@ikesyo
Copy link
Member

ikesyo commented Jun 29, 2018

beCloseTo

The problem here is that we can't provide DefaultDelta value naturally since that must be a generic value of T: FloatingPoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants