Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue70 antialiasing as option #79

Merged
merged 5 commits into from
Nov 1, 2014

Conversation

yodalee
Copy link
Contributor

@yodalee yodalee commented Oct 28, 2014

#70

I add the option in to dialog and the related Boolean value. I also add a parameter to set antialiasing property of VeiwPainter. However, I cannot tell this is working or not.

@yodalee
Copy link
Contributor Author

yodalee commented Oct 29, 2014

@in3otd can you help me examine this code? I add a checkbox in setting dialog but I cannot tell whether it work properly.

@in3otd
Copy link
Contributor

in3otd commented Oct 29, 2014

sure, wanted to do yesterday but got too many things to do... will try to find some time later...

…ng setting is not found in the settings file
…d caused the anti-alias setting not to work properly
@in3otd
Copy link
Contributor

in3otd commented Nov 1, 2014

@yodalee , did correct a couple of mistakes in the code, see my pull request to your fork, now the AA option is working fine, thanks.

@yodalee
Copy link
Contributor Author

yodalee commented Nov 1, 2014

Thank you, I just merged your branch and this pull request is resend.
Now I can tell the difference between drawing with/without AA lol

Issue70 antialiasing as option
Fix typo and parameter errors
@guitorri
Copy link
Member

guitorri commented Nov 1, 2014

This is looking good! Let us think about the need for issues to track options for text, drawings...

guitorri added a commit that referenced this pull request Nov 1, 2014
@guitorri guitorri merged commit 6f5eef9 into Qucs:master Nov 1, 2014
@yodalee yodalee deleted the issue70-antialiasing-as-option branch November 1, 2014 19:19
@yodalee yodalee mentioned this pull request Nov 9, 2014
@guitorri guitorri added this to the 0.0.19 milestone Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants