Instantiate QApplication sooner so applicationDirPath() is valid #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applicationDirPath() was used before a QApplication was instantiated so it returned an empty path. This caused the application language files path to be computed incorrectly.
|
All applications seem to find the translations here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...now is my turn to realize i did a sloppy review 😒
In #501 the path for the language files was changed to be relative to the application path, but if a
QApplication()object is not instantiated before callingQCoreApplication::applicationDirPath()this latter actually returns an empty path, so the language files are not found (unless you run the application from theprefixdirectory).This was already fixed for
qucshelpin #473, but after #501 all the other tools needed to be updated .I have checked this to work but please double/triple check...