qucslib: Searchboxes fix crash #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a library component does not match one of the types in SymbolWidget::createSymbol, the variables x1, x2, y1, y2 may end up with unknown values. This can cause the `setMinimumSize` to fail a bound size assertion crashing the application. This patch add default values for these variables.
Issue warning message in case a (user) library contains a component which its symbols is not yet mapped or implemented in qucs-lib. The component may be implemented correctly in qucs, but its symbol is not matched (and drawn) in qucs-lib. The painting code is somewhat duplicated.
Connecting from COMPAT signal (QAction::activated(int))
guitorri
added a commit
that referenced
this pull request
Jan 25, 2016
qucslib: Searchboxes fix crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Qucs-lib crash while testing #303.
Because the component (symbol for)
hicumL2V2p31nwas not found, variables ended up uninitialized.The variables were used to reside the window according to he symbol size. When uninitialized it could could be resized to random values, eventually crashing the application (fail assert in Qt).
This patch attempts to make it more robust and inform the user about missing default symbols.
TODO: registering each component again on qucs-lib (and copying the default symbol) seems redundant.