-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigned About dialog #252
Conversation
//all->setSpacing(0); | ||
|
||
QLabel *iconLabel = new QLabel(); | ||
iconLabel->setPixmap(QPixmap(QString("qucs/bitmaps/hicolor/128x128/apps/qucs.png"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible this will be a resource reference later.
void setAuthorsText(void); | ||
void setTrText(void); | ||
|
||
std::array<QString, 8> currAuths; // current Qucs authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::array
seems not yet available in clang 3.4...
https://travis-ci.org/Qucs/qucs/jobs/61680030#L7991
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, well... but with the clang 3.3 I'm using here it compiles fine (!). I think I forgot an #include <array>
anyway, let me check...
We should unify the artwork on logos, icons and website (pick fonts and colors)... I scrapped some files from the mailing list, I will put them somewhere accessible. However the ones I have are not SVG files... @nvdl which font did you use? |
polishing the logo It is already on the web, just added some gradient to give a 3D feel. Where is this stuff going on? Any Wiki (or something) where we can propose and decide? |
365bd8d
to
b48a6f0
Compare
I have cleaned up the code a little, should be good to merge now, please check. |
// link to home page, help mailing list, IRC ? | ||
supportText = tr("Home Page") + " : <a href='http://qucs.sourceforge.net/'>http://qucs.sourceforge.net/</a><br/>"+ | ||
tr("Documentation start page") + " : <a href='http://qucs.sourceforge.net/docs.html'>http://qucs.sourceforge.net/docs.html</a><br/>" + | ||
tr("Components reference manual") + " : <a href='http://qucs.sourceforge.net/doc/0.0.19/html/index.html'>http://qucs.sourceforge.net/doc/0.0.19/html/index.html</a><br/>" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is dead.
I moved the component reference to https://github.com/guitorri/qucs-manual. Perhaps we can move it to the Qucs organization. It is still needs some work thou.
Perhaps the Readme.md resources would fit here nicely.
This looks great!
|
ok, which link should I use then for the Component Reference Manual? Will you put it back on SF or keep it just in http://guitorri.github.io/qucs-manual/ ? It's a WIP, as many things here, but already quite good IMHO. |
I will move the qucs-manual to the Qucs organization. I just want to avoid publishing links that will soon be broken. |
Done, moved to https://github.com/Qucs/qucs-manual |
yes, the webpage: http://qucs.github.io/qucs-manual/ |
b48a6f0
to
40e6748
Compare
updated the authors list, updated the doc link and the text in the Support page and disabled the Ctrl-Wheel event. Took a while to find out who was actually handling it (not the QTextBrowser but its viewport). Should be ok now. |
Every time the corresponding Tab is selected, the order of Authors or Translators will be randomly shuffled.
Added in3otd to the Current Authors list. Some more links and explanations in the Support Tab (IRC, Resources page, etc.)
To avoid having the user accidentally zooming the text while scrolling using the mouse wheel, the Ctrl-Wheel event is filtered out.
Very nice! Congrats! |
Do not merge yet, this is still a WIPEdit: cleaned up a bit the commits, should be ok now.
Here is the redesigned About dialog, as per #172 . Please take a look at the dialog and code and check if it's ok. Might still need some (minor) fixes.