Modular fix cmake #1040
Closed
Modular fix cmake #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.h, .hpp, .hxx and .H seen ok https://github.com/KDE/automoc/blob/master/Automoc4Config.cmake
Automoc lists all files that need to be moc'ed. This creates a condition where redeclaration may occur. It seems that all moc'ed files end up on the same translation unit? Anyway, using QT5_WRAP_CPP() to manually run moc on each header seems to do the trick. https://cmake.org/cmake/help/v3.20/prop_tgt/AUTOMOC.html
|
On Mon, Mar 15, 2021 at 03:23:24PM -0700, Guilherme Brondani Torri wrote:
Taking a step back the .cc headers should have worked. The .hqt don't work with cmake. I picked .hxx for a change...
Up to you if you want to revert.
Thanks for figuring out the compilation units with cmake. It seems we
are getting there.
- .cc files do not work with moc. It has to be .h*. Symptoms are it wont
print '#include "file.cc"'. Regardless of "autoinclude".
- QT_PLUGIN_SRC = ..cc was a temporary hack with side effects. Must
always list the source files.
- autotools treats headers differently. a .h, .hxx (etc) file
listed in *_SOURCE will be silently dropped.
I'd really like to stick to .hqt files now if possible, as these align
with the plan, and common use of file extensions. Plugins will be built
through attach.cc (at least where this is desired). For this, extensions
should map to rules, with little magic. I.e. "attach my_stuff.hqt" will
run moc, "attach other_stuff.cc" must not. Will have to rely on
extensions anyway, "attach more.py" etc.
With Make, .hqt -> .cc -> .so chains are trivial. Do you know why
QT5_WRAP_CPP does not like .hqt? I would hope this can be fixed or
implemented some other way with cmake (create symlinks?).
|
|
cmake does not seem to mind .hqt. i picked the two other commits. This leaves minor issues only. \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qucs build and runs. Tested both cmake and autotools.
I am afraid the issues I had were due to cmake and its automoc feature.
Somehow it includes all the code to be moc'ed. This created collision of definitions (F, p1,...).
I guess all the code end up on the same translation unit.
Taking a step back the .cc headers should have worked. The .hqt don't work with cmake. I picked .hxx for a change...
Up to you if you want to revert.