Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non GPL verilog-a models #421

Closed
4 tasks done
guitorri opened this issue Jan 27, 2016 · 8 comments
Closed
4 tasks done

Remove non GPL verilog-a models #421

guitorri opened this issue Jan 27, 2016 · 8 comments
Milestone

Comments

@guitorri
Copy link
Member

See #390 for context.

It is time for a release.
The best we can do now is to somehow disable the verilog-a models from the build system and skip them from distribution.

Later on we figure out a way to either provide them in another format. Or if we are lucky, the authors of those modules will change they licenses.

Todo:

  • Add the #define GPL (or another name) definition as build option.
  • Update the CMake files.
  • Remove non-GPL files from repository
  • Instruct qucs-test to skip simulations with the non-free models
@guitorri guitorri added this to the 0.0.19 milestone Jan 27, 2016
@guitorri
Copy link
Member Author

Something like master...guitorri:remove-non-GPL-from-dist

@felix-salfelder
Copy link
Member

Later on we figure out a way to either provide them in another format.

we must provide a way to use verilog models with qucs (in a straightforward way, without linking). then provide a package with verilog models under an appropriate license.

Or if we are lucky, the authors of those modules will change they licenses.

even if this happens (i do not expect miracles), someone will implement another model that we might want to provide.

Add the #define GPL (or another name) definition as build option.

licenses are mandatory, not optional. your idea is essentially to bypass the license. if this was legal, nobody would have to adhere to the GPL (in this case) very much. IANAL, but i can ask debian-legal about it...

@guitorri
Copy link
Member Author

You are right. :)
The dynamic loader can be improved to allow straightforward linking as you say.
Non-GPL stuff should not be in the repo.

@guitorri guitorri changed the title Remove from tarball non GPL verilog-a models Remove non GPL verilog-a models Jan 28, 2016
@felix-salfelder
Copy link
Member

You are right. :)

not in a way that is inherently obvious to me. (i tried to read the GPL once more).

The dynamic loader can be improved to allow straightforward linking as you say.

i think we need to introduce some kind of (loadable) model library. (let's talk about that on saturday.)

Non-GPL stuff should not be in the repo.

that would be nice. can you set up a qucs-models-nonfree repo, so we have a place to put them?

i think, what we must do, is remove all traces of "linking GPL code with non-GPL" code. that is, remove all references to GPL incompatible stuff (contained in GPLd source code) and in particular, all build rules that involve non-free sources...

@guitorri
Copy link
Member Author

I did not read the GPL again, but as I think now, the distributed tarball should reflect the repository 1-to-1 (ignoring the autogenerated stuff). Some distributions have ways to build packages directly from a repository.

If we had a serious license infringement (think DMCA) they could shut our repository down....

We sill will talk for sure, there are more issues that need to be tackled for a loadable models and libraries.

A non-free repo sounds right. We should keep the original file (when allowed) and the patches needed to process and load them.

Later today I will continue on removing the traces of non-GPL.

Should we rewrite history as well??

@guitorri
Copy link
Member Author

Please take a look at #425. I think I removed everything.

@felix-salfelder
Copy link
Member

Should we rewrite history as well??

a really good question. let's not do this.

that said: i have no clue about the consequences, but i hope you all agree with me.

@guitorri
Copy link
Member Author

guitorri commented Feb 9, 2016

The worst case scenario is someone forcing us to do that (unlikely). In that case we either carefully rewrite history (at the cost of every fork/copy out there becoming potentially headless), or the project fork itself from the point after the models where removed (throw away the whole history before that).
I guess we leave it like that for the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants