Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging from the library dock window make a corrupt netlist #39

Closed
hoditohod opened this issue Sep 10, 2014 · 5 comments
Closed

Dragging from the library dock window make a corrupt netlist #39

hoditohod opened this issue Sep 10, 2014 · 5 comments

Comments

@hoditohod
Copy link

Version: Qucs 0.0.18 official windows build.

How to reproduce:

  • create empty schematic
  • open a select a diode bridge in the dock window and drag it into the schematic
  • press simulate

Observed outcome: syntax error in netlist
line 12: checker error, subcircuit type Bridges_KBPC1005' requires 4 nodes in Sub:_net0', found 3

Netlist:

# Qucs 0.0.18  C:/Users/Gyorgy Szekely/.qucs/zxcfjksdn_prj/xdfgf.sch

.Def:Bridges_KBPC1005 _net0 _net1 _net2 _net3
      Diode:D1 _net0 _net1 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
      Diode:D2 _net2 _net1 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
      Diode:D3 _net3 _net2 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
      Diode:D4 _net3 _net0 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
    .Def:End


Sub: _net0 _net1 _net2 _net3 Type="Bridges_KBPC1005"

Note the missing subnet name!

Workaround:

  • click Manage Libraries in the dock window
  • locate the diode bridge in the dialog
  • drag the symbol above the ! Drag n'Drop me! label

The netlist is correct in this case:

# Qucs 0.0.18  C:/Users/Gyorgy Szekely/.qucs/zxcfjksdn_prj/xdfgf.sch

.Def:Bridges_KBPC1005 _net0 _net1 _net2 _net3
      Diode:D1 _net0 _net1 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
      Diode:D2 _net2 _net1 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
      Diode:D3 _net3 _net2 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
      Diode:D4 _net3 _net0 Is="9.2e-9" N="1.75" Rs="42e-3" Cj0="124e-12" Vj="0.75" M="0.333" Fc="0.5" Tt="4.32e-6" Bv="50" Ibv="18e-6" Af="1" Kf="0"  
    .Def:End


Sub:D1 _net0 _net1 _net2 _net3 Type="Bridges_KBPC1005"
@guitorri guitorri added this to the 0.0.19 milestone Sep 10, 2014
@guitorri
Copy link
Member

Dragging from the dock does not instantiate the component properly.
See below the schematic section for a bridge dragged from the dock and another from the Qucs Library Tool.

<Components>
  <Lib * 1 220 130 0 0 0 0 "Bridges" 0 "GBU4G" 0>
  <Lib D1 1 390 210 20 20 0 0 "Bridges" 0 "GBU4G" 0>
</Components>

@ra3xdh
Copy link
Contributor

ra3xdh commented Sep 12, 2014

Bug is confirmed for Linux. This bug appears for only components that contains subcircuits (Diode bridges, NMOSFETS with diode, etc., but not opamps). Single transistors can be placed on schematic without problems.

@guitorri
Copy link
Member

These libs seem to trigger the issue:

 BRIDGES    LIB
 MOSFETs    LIB
 NMOSFETs   LIB
 PMOSFETs   LIB
 Varistor   LIB
 ZDiodes    LIB

@yodalee
Copy link
Contributor

yodalee commented Sep 20, 2014

I cannot reproduce this, since I can only add these element by drop and drag them in the "manage libraries", and the sub-circuit will be properly initialize in this way.

@ra3xdh ra3xdh mentioned this issue Oct 2, 2014
guitorri added a commit that referenced this issue Oct 2, 2014
@guitorri
Copy link
Member

guitorri commented Oct 2, 2014

Thank you @ra3xdh !

@guitorri guitorri closed this as completed Oct 2, 2014
@guitorri guitorri changed the title Dragging from the dock window make a corrupt netlist Dragging from the library dock window make a corrupt netlist Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants