Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some qucssettings is unused, or unable to be set #112

Closed
yodalee opened this issue Nov 11, 2014 · 3 comments
Closed

Some qucssettings is unused, or unable to be set #112

yodalee opened this issue Nov 11, 2014 · 3 comments

Comments

@yodalee
Copy link
Contributor

yodalee commented Nov 11, 2014

I'm change QucsSettings to a singleton setting class. Here are some weird properties I found during porting:

  • largeFontSize unable to set in QucsSettingDialog
  • FileTypes is unused
  • Highlighted color is unused

to be added lol
@yodalee
Copy link
Contributor Author

yodalee commented Nov 15, 2014

@in3otd Can you help me fix this? Just add largeFontSize to qucssettingdialog.cpp, since where to use FileTypes and Highlighted color is unsure now. In the same time, you can add DrawTextInAntiAliasing along with DrawInAntiAliasing, and fixes the init() argument you forgot to fix.

@in3otd
Copy link
Contributor

in3otd commented Nov 15, 2014

ok, I'll try to do this over this weekend...

@in3otd in3otd mentioned this issue Nov 18, 2014
Merged
@yodalee
Copy link
Contributor Author

yodalee commented Nov 22, 2014

Merged and close.

@yodalee yodalee closed this as completed Nov 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yodalee @in3otd