Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve static analysis tests with JET [$200] #130

Closed
Krastanov opened this issue Jul 9, 2024 · 8 comments · Fixed by #152
Closed

Improve static analysis tests with JET [$200] #130

Krastanov opened this issue Jul 9, 2024 · 8 comments · Fixed by #152
Labels
bounty:reserved bounty:200 bug bounty There is an award for solving this issue.

Comments

@Krastanov
Copy link
Member

Bug bounty logistic details (click to expand)

To claim exclusive time to work on this bounty either post a comment here or message skrastanov@umass.edu with:

  • your name
  • github username
  • (optional) a brief list of previous pertinent projects you have engaged in

Currently the project is claimed by no one until ....

If you want to, you can work on this project without making a claim, however claims are encouraged to give you and other contributors peace of mind. Whoever has made a claim takes precedence when solutions are considered.

You can always propose your own funded project, if you would like to contribute something of value that is not yet covered by an official bounty.

Project: "Improve static analysis tests with JET" [$200]

We use JET for static analysis of the codebase. To claim this bounty, fix 2/3 of the reported warnings. Some of them are false positives that can be removed with extra type annotation. Some of them are due to dependencies, in which case you can simply blacklist the dependency (as already done). See the test_jet.jl test file and the JET CI run for the current state of affairs.

Required skills: General Julia and JET skills.

Reviewer: Stefan Krastanov

Duration: 1 month

Payout procedure:

The Funding for these bounties comes from the National Science Foundation and from the NSF Center for Quantum Networks. The payouts are managed by the NumFOCUS foundation and processed in bulk once every two months. If you live in a country in which NumFOCUS can make payments, you can participate in this bounty program.

Click here for more details about the bug bounty program.

@Krastanov Krastanov added bug bounty There is an award for solving this issue. bounty:200 labels Jul 9, 2024
@chainparser

This comment was marked as outdated.

@Krastanov

This comment was marked as outdated.

@chainparser

This comment was marked as outdated.

@Krastanov
Copy link
Member Author

Here are some notes on Julia that might be useful:

And here is the link from where you can see all bug bounties: https://github.com/QuantumSavory/.github/blob/main/BUG_BOUNTIES.md

You can also search for the tag "good first issue".

@chainparser

This comment was marked as outdated.

@lgoettgens
Copy link
Contributor

lgoettgens commented Sep 8, 2024

@Krastanov I would like to give this a shot. I am already a bit somewhat familiar with fixing JET related issue from my day job, see e.g. Nemocas/Nemo.jl#1762.

Currently, there are 146 issues reported by JET:

@test length(JET.get_reports(rep)) <= 146

2/3 of them is 97, so I would try to decrease the number by at least that amount.

@Krastanov
Copy link
Member Author

That would be great! Thank you for your interest! I will mark this as reserved.

@Krastanov
Copy link
Member Author

If there is a problem with some API decision or something in a dependency, do not hesitate to post and ask for suggestions or help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:reserved bounty:200 bug bounty There is an award for solving this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants