Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH - Pull JupyterLab build and install steps into reusable action #27

Closed
gabalafou opened this issue Nov 4, 2022 · 1 comment · Fixed by #30
Closed

ENH - Pull JupyterLab build and install steps into reusable action #27

gabalafou opened this issue Nov 4, 2022 · 1 comment · Fixed by #30
Assignees
@trallard
Labels
area: testing 🔍 needs: discussion 💬 type: enhancement 💅🏼 New feature or request

Comments

@gabalafou
Copy link
Contributor

gabalafou commented Nov 4, 2022 •
edited
Loading

Currently there are a few steps in .github/actions/jlab-a11y-test/action.yml but they could be pulled out into a separate action.
@trallard trallard moved this to 🆕 New in jupyter-a11y-tools 🛠 Nov 4, 2022
@gabalafou
Copy link
Contributor Author

gabalafou commented Dec 8, 2022 •
edited
Loading

Idea / add-on to this issue:

Create an action that takes as input:

  1. jupyterlab commit SHA
  2. (optional) lumino commit SHA
    • if lumino commit SHA is not provided, it will build JupyterLab with whatever version of Lumino comes in the provided JupyterLab SHA.

The idea is that this would make it easy to run accessibility tests against a change in Lumino combined with JupyterLab.

@gabalafou gabalafou mentioned this issue Dec 8, 2022
Closed
@trallard trallard changed the title Pull JupyterLab build and install steps into reusable action ENH - Pull JupyterLab build and install steps into reusable action Dec 16, 2022
@trallard trallard mentioned this issue Jan 17, 2023
Merged
3 tasks
@trallard trallard moved this from Todo 📬 to In Review 👀 in Jupyter a11y CZI grant 🚀 Jan 18, 2023
@trallard trallard moved this from Backlog 🗃 to In progress 🏗 in jupyter-a11y-tools 🛠 Jan 18, 2023
@trallard trallard self-assigned this Jan 27, 2023
@github-project-automation github-project-automation bot moved this from In progress 🏗 to Done 💪🏾 in jupyter-a11y-tools 🛠 Mar 20, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 💪🏾 in Jupyter a11y CZI grant 🚀 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trallard trallard

Labels
area: testing 🔍 needs: discussion 💬 type: enhancement 💅🏼 New feature or request
Projects
Jupyter a11y CZI grant 🚀
Status: Done 💪🏾
jupyter-a11y-tools 🛠
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT - Split Lab build into an action of its own Quansight-Labs/jupyter-a11y-testing
2 participants
@gabalafou @trallard