Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port CommutationChecker to rust #12702

Closed
mtreinish opened this issue Jul 1, 2024 · 0 comments · Fixed by #12870
Closed

Port CommutationChecker to rust #12702

mtreinish opened this issue Jul 1, 2024 · 0 comments · Fixed by #12870
Assignees
@sbrandhsn
Labels
performance priority: high Rust This PR or issue is related to Rust code in the repository type: feature request New feature or request
Milestone
1.3 beta

Comments

@mtreinish
Copy link
Member

What should we add?

Now that we have infrastructure for gates in rust we should port the CommutationChecker class defined in: https://github.com/Qiskit/qiskit/blob/ed87f2fa502ea0d63b072c227b5e813b6320fa56/qiskit/circuit/commutation_checker.py
to rust. This will be needed for #12270 as this class is the key component of the CommutationAnalysis pass that does all the analysis.
@mtreinish mtreinish added the type: feature request New feature or request label Jul 1, 2024
@mtreinish mtreinish added this to the 1.2.0 milestone Jul 1, 2024
@mtreinish mtreinish added performance Rust This PR or issue is related to Rust code in the repository labels Jul 1, 2024
@sbrandhsn sbrandhsn self-assigned this Jul 2, 2024
@mtreinish mtreinish modified the milestones: 1.2.0, 1.3 beta Jul 24, 2024
@sbrandhsn sbrandhsn mentioned this issue Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrandhsn sbrandhsn

Labels
performance priority: high Rust This PR or issue is related to Rust code in the repository type: feature request New feature or request
Projects
None yet
Milestone
1.3 beta
Development

Successfully merging a pull request may close this issue.

Oxidize commutation checker sbrandhsn/qiskit
2 participants
@mtreinish @sbrandhsn