Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

canonicalize_control_flow will be removed in Qiskit 1.0 #805

Closed
kt474 opened this issue Feb 1, 2024 · 2 comments
Closed

canonicalize_control_flow will be removed in Qiskit 1.0 #805

kt474 opened this issue Feb 1, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@kt474
Copy link
Member

kt474 commented Feb 1, 2024

We use canonicalize_control_flow in our transpiler tests here but it is being removed in Qiskit 1.0 (see Qiskit PR )

Can this be replaced with QuantumCircuit.__eq__?

@taalexander @dieris

@kt474 kt474 added the type: bug Something isn't working label Feb 1, 2024
@taalexander
Copy link
Contributor

I think we need some input from @jakelishman, this was originally needed to make sure eq evaluated correctly

@jakelishman
Copy link
Member

Kevin asked me offline before this - since Qiskit/qiskit#10367, QuantumCircuit.__eq__ should have been doing all the necessary canonicalisation within itself, so (in theory) it should work to remove the explicit call.

@kt474 kt474 closed this as completed Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants