Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for markdown code examples #666

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Jan 22, 2024

Minor tweaks to make the code examples run. Closes #609.

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do you know why we didn't know about these failures earlier?

@frankharkins
Copy link
Member Author

I assume these were human error when creating the files, then never got tested since.

@frankharkins frankharkins added this pull request to the merge queue Jan 22, 2024
@Eric-Arellano
Copy link
Collaborator

then never got tested since.

I thought the CI check would have caught the issues? Is it because the CI check only runs on changed notebooks?

Merged via the queue into main with commit 690a9ac Jan 22, 2024
4 checks passed
@frankharkins frankharkins deleted the FH/code-examples branch January 22, 2024 16:28
@frankharkins
Copy link
Member Author

Is it because the CI check only runs on changed notebooks?

Yes that's right; markdown needs testing manually

@Eric-Arellano
Copy link
Collaborator

Ah, duh. Didn't realize this is MDX. Got it. Thanks!

frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Minor tweaks to make the code examples run. Closes Qiskit#609.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit all non-api ref code blocks in preparation for qiskit 1.0
2 participants