API generation script - Fix loadImages function #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Jan 22, 2024
|
Good idea @frankharkins! Thank you both for the review |
Eric-Arellano
approved these changes
Jan 22, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
The `processHtml.ts` script assumes that we always have an `src`
attribute in the `img` tags, and even though this is true for the latest
API versions, for Qiskit historical versions, we can find cases like the
following example:
**Qiskit v0.41 release_notes.html line 23360**
```html
<div class="animation">
<img id="_anim_imga6548212aea7457ca5d2f940fabeaea3">
<div class="anim-controls">
<input id="_anim_slidera6548212aea7457ca5d2f940fabeaea3" type="range" class="anim-slider"
```
This PR adds an early return to the `loadImage` function to skip the
images without a `src` attribute given that we can't find the image in
the `_images` folder of the GitHub artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
processHtml.tsscript assumes that we always have ansrcattribute in theimgtags, and even though this is true for the latest API versions, for Qiskit historical versions, we can find cases like the following example:Qiskit v0.41 release_notes.html line 23360
This PR adds an early return to the
loadImagefunction to skip the images without asrcattribute given that we can't find the image in the_imagesfolder of the GitHub artifact.