Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor tags are still missing #662

Merged
merged 51 commits into from
Jan 19, 2024
Merged

Anchor tags are still missing #662

merged 51 commits into from
Jan 19, 2024

Conversation

abbycross
Copy link
Collaborator

Final commit wasn't pushed to #589 !

abbycross and others added 30 commits January 5, 2024 12:19
@abbycross
first pass at adding custom anchor tag
c8ffdb3
@abbycross
remove tiers from show/hide twisties
ab7959c
@abbycross
create new page
7f673a1
@abbycross
add to toc
3fffcae
@abbycross
add metadata
7a673fb
@abbycross
remove twisties
35331c5
@abbycross
create new img folder and move img there
3cbf79d
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
6fc0798 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
16f76c0 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
4ee0f7e 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
db380be 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
2a7b953 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
ef902af 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
8605918 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
74172ba 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
2e55d77 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
af78eb8 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
573bf9f 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
91e23a2 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
990e441 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
6391706 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
8c78d3d 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
de82534 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
0e8c573 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
bf4159d 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
6557cbe 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
8ec43e3 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
d673552 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
f94d343 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
39b5d65 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
abbycross and others added 13 commits January 8, 2024 14:14
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
3d43243 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
2335ee3 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
f9d5fd4 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
962a193 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
2679bbc 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross @beckykd
Update docs/start/qiskit-versioning.mdx
9a03de5 
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
@abbycross
Update docs/start/qiskit-versioning.mdx
5ad2859
@abbycross @Eric-Arellano
code review
0a94953 
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@abbycross
restore to original
ffe63ad
@abbycross
bring over Becky's edits
3cd7b37
@abbycross
restore image file to old path
04ce20d
@abbycross
delete versioning page
e6fc0fd
@abbycross
remove from toc
a21a000
@abbycross abbycross self-assigned this Jan 19, 2024
@abbycross abbycross requested a review from beckykd January 19, 2024 21:34
@abbycross abbycross added this pull request to the merge queue Jan 19, 2024
Eric-Arellano
Eric-Arellano reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it adds new anchor tags to me? Only that it dedents the text inside <details>

@abbycross abbycross removed this pull request from the merge queue due to a manual request Jan 19, 2024
@abbycross
Copy link
Collaborator Author

Hahaha thanks @Eric-Arellano you're right.... I am having a large problem with GitHub desktop and this final commit. Trying again!!

@abbycross
Copy link
Collaborator Author

Ok I've actually committed and pushed the commit this time. Whew!

@abbycross abbycross added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 3a96134 Jan 19, 2024
4 checks passed
@abbycross abbycross deleted the anchor-tags branch January 19, 2024 21:46
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
@abbycross @beckykd @Eric-Arellano
Anchor tags are still missing (Qiskit#662)
1c20349 
Final commit wasn't pushed to Qiskit#589 !

---------

Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano left review comments

@beckykd beckykd beckykd approved these changes

Assignees

@abbycross abbycross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abbycross @Eric-Arellano @beckykd