Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the math block's indentation from the API docs #1123

Merged
merged 29 commits into from
Apr 4, 2024

Conversation

arnaucasau
Copy link
Collaborator

@arnaucasau arnaucasau commented Apr 3, 2024

Turns out the math blocks (latex expressions between double dollars $$) can't be indented more than once without making the pages not render. After introducing the MDX components for classes, functions, and attributes on #1026, we can't guarantee only one level of indentation, and this PR adds a new function to remove the indentation as a postprocess of all the MDX files.

Example of a math expression that was not rendering before:
Captura desde 2024-04-03 23-35-05

@arnaucasau arnaucasau marked this pull request as ready for review April 3, 2024 21:34
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@arnaucasau arnaucasau requested a review from Eric-Arellano April 4, 2024 10:50
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arnaucasau arnaucasau added this pull request to the merge queue Apr 4, 2024
Merged via the queue into Qiskit:main with commit 491085a Apr 4, 2024
5 checks passed
@arnaucasau arnaucasau deleted the math-block-indentation branch April 4, 2024 13:45
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Turns out the math blocks (latex expressions between double dollars
`$$`) can't be indented more than once without making the pages not
render. After introducing the MDX components for classes, functions, and
attributes on Qiskit#1026, we can't guarantee only one level of indentation,
and this PR adds a new function to remove the indentation as a
postprocess of all the MDX files.

Example of a math expression that was not rendering before:
![Captura desde 2024-04-03
23-35-05](https://github.com/Qiskit/documentation/assets/47946624/b3ecfb8d-b7c7-40c6-84b1-da0965ec0c15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants