Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Build does not compile with flag '--profile=release' #3

Open
lollogrottesi opened this issue Feb 20, 2025 · 2 comments
Open

bug: Build does not compile with flag '--profile=release' #3

lollogrottesi opened this issue Feb 20, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@lollogrottesi
Copy link

Hello,

I'm encountering an issue when attempting to build the project using the release profile. The command I executed is as follows:

git submodule update --init

cargo build --profile=release

I am using Cargo version 1.84.1.

During the build process, I receive the following error:

error[E0277]: the trait bound `(): CryptoRngCore` is not satisfied
   --> aurora/src/adapters/libcrux/X25519MLKEM768/keymgmt_functions.rs:290:26
    |
290 |         self.encapsulate(&mut rng)
    |              ----------- ^^^^^^^^ the trait `CryptoRng` is not implemented for `()`
    |              |
    |              required by a bound introduced by this call

Could someone assist with this issue or suggest any potential fixes?

Thank you!

@lollogrottesi lollogrottesi added the bug Something isn't working label Feb 20, 2025
@romen
Copy link
Member

romen commented Feb 21, 2025

Hi @lollogrottesi, thanks for reporting this!

At the moment, as we are still in a development phase, it is expected that only the debug builds are successful.

I.e., even after fixing the error you reported above, there are other todo!() lines that are triggered only in release builds which would result in panic/SegFault when loading a "release" build of aurora as a provider in OpenSSL.

We intentionally decided to break release builds, to ensure users are aware this is still in development and not ready for production.

@romen
Copy link
Member

romen commented Feb 21, 2025

We plan to fix this by the release of v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants