Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicklook copies file path in voidtools Everything #593

Closed
Darthagnon opened this issue Dec 31, 2019 · 22 comments
Closed

Quicklook copies file path in voidtools Everything #593

Darthagnon opened this issue Dec 31, 2019 · 22 comments

Comments

@Darthagnon
Copy link

Steps to reproduce:

  1. Copy a text string (e.g. web address)
  2. Use Everything to find a .docx or other editable text file.
  3. Navigate to text file in Everything using arrow keys, and press Enter/Return to open it.
  4. Ctrl+V paste your clipboard contents. Your text string is now gone, and replaced by the filepath of the opened text file.

This is apparently a bug in QuickLook, not in Everything.

It's very annoying when copying a web address and I try to use my keyboard only to navigate to a notes.docx to paste the web address. It forces me to use my mouse

@xupefei
Copy link
Member

xupefei commented Jan 2, 2020

I believe this issue has been fixed in #521.
Try the Nightly version.

@Darthagnon
Copy link
Author

I got the nightly version from https://ci.appveyor.com/project/xupefei/quicklook/build/artifacts and so far, so good, looks like it's fixed. I'll update this post if there's any further problems.

@Darthagnon
Copy link
Author

Update: The nightly I installed fixed the "Space copies file path" bug, but it now has another bug, where, as long as QuickLook is running, if I select a file in Everything and Ctrl+X it, the clipboard is cleared after half a second or so.

Is there a new nightly that would have fixed this issue?

@xupefei
Copy link
Member

xupefei commented Feb 2, 2020

What does Ctrl+X do in Everything?

@Darthagnon
Copy link
Author

Cuts a file, if a file is selected. Everything uses default Windows Explorer controls in general (Ctrl+C/V/X, Space previews with QuickLook, etc.)


I'm thinking it might have been a one-off bug, as I haven't seen that behaviour since.

@HASJ
Copy link

HASJ commented Mar 31, 2020

Any progress on this? Because since QuickLook v3.6.5 and now in v3.6.6, while using Everything, pressing Space does nothing at all.
At least the clipboard overwrite is gone.

@Darthagnon
Copy link
Author

@HASJ what OS are you on? It works for me on Win10 v1709; I'll test soon on Win7

@HASJ
Copy link

HASJ commented Apr 2, 2020

@Darthagnon Win10 x64 v1909
Everything v1.4.1.969

@hllmtl
Copy link

hllmtl commented Apr 5, 2020

@HASJ Does it work if you run QuickLook as administrator?

@Darthagnon
Copy link
Author

Darthagnon commented Apr 6, 2020

EDIT2: Weird. I tried again and it worked fine. Didn't copy the file path. Dunno, maybe it's intermittent? Will update here if it happens again.

Further tests my end confirm: this issue is not fixed. I can't speak for @HASJ's problem, as QuickLook works for me, but v3.6.6 is back to copying file paths again in Everything (this was fixed for a while in prerelease build QuickLook-3.6.5-37-g2d8a38f).

Example: I copy a web address from browser. I press Ctrl+Alt+Space to open Everything and search for a Word.docx. I navigate to it via keyboard, and open it with Enter. I paste the clipboard into the document. The clipboard pastes the document's file path, not the web address I copied - this issue is caused by QuickLook, as confirmed by Everything's developers.

QuickLook v3.6.6 is broken again; gonna have to downgrade back to QuickLook-3.6.5-37-g2d8a38f.

EDIT: here's the last working nightly build that doesn't copy the file path from Everything: https://drive.google.com/open?id=1ZvTG13Yd0OhR9yFWdvfogBAwDmn3QjVF
Build 618 direct link (NB will expire in 6 months):
https://ci.appveyor.com/project/xupefei/quicklook/builds/28799838/artifacts

Here's the Everything forum thread where this is discussed:
https://www.voidtools.com/forum/viewtopic.php?f=5&t=8687

@HASJ
Copy link

HASJ commented Apr 7, 2020

image
@Darthagnon @N3PP I found the issue. If you mark Everything > Tools > General > Results > Double quote copy as path as on, QuickLook can't use the path.
Clipboard is still being overwritten, however.

@xupefei
Copy link
Member

xupefei commented Apr 8, 2020

QuickLook has to copy the path to be able to work in Everything. In the latest version (3.6.6) of QuickLook:

  • The "copy path" operation will only happen when a user previews a file from Everything.
  • If the user just uses Everything while QuickLook is running, QuickLook will not copy the file path (i.e., will not overwrite the clipboard).

The ultimate solution would be Everything to provide a SendMessage/PostMessage API that returns the full path of the selected file.

@Darthagnon
Copy link
Author

Darthagnon commented Apr 8, 2020

Tested with QuickLook v3.6.7:

  • Copied dankmeme.jpg in \Downloads\
  • Ctrl+Alt+Space to open Everything, search for my dank memes folder
  • Didn't preview anything with QuickLook. Pressed Enter to open folder.
  • dank memes folder opened in Explorer, Ctrl+V to paste the .jpg into the folder.
  • Nothing happens. The .jpg has been cleared from the clipboard and replaced with the folder path.

@xupefei Maybe it has something to do with the activation method for Everything? e.g. I use Ctrl+Alt+Space - maybe sometimes, Quicklook grabs that Space and gets confused? Or is it interpreting "Enter" to mean something? Everything worked fine with QuickLook-3.6.5-37-g2d8a38f (Build 618).

@HASJ What activation key combo do you use for QuickLook? (Off topic, but how did you get QuickLook dark like that?! Looks sweet!)

@xupefei
Copy link
Member

xupefei commented Apr 9, 2020

Strange. I tried on my machine but I can't reproduce this issue.
Here is what I did:

  1. Install Everything Service.
  2. image.
  3. Copy some texts.
  4. On Desktop, press Ctrl+Alt+Space to bring up the Everything window.
  5. Type something, press the Down Arrow key, then press Enter.
  6. An explorer window opens.
  7. Press Ctrl+V in a notepad, I can see the texts I copied in Step 3.

I an using QuickLook 3.6.7 and Everything 1.4.1.969 (x64). Any comments?

@Darthagnon
Copy link
Author

Darthagnon commented Apr 9, 2020

No idea :'( Maybe goblins in my PC. Thank you for testing! From your post, I realised there's an update for Everything. Maybe that'll change things. It doesn't seem to happen with 100% certainty for me

EDIT: tested with updated Everything; still happens :'(

@HASJ, what programs do you normally keep running as services & where do you have QuickLook/Everything installed? Maybe there's a common denominator for us.

My setup:

  • Quicklook installed to: C:\Windows Tweaks\Quicklook
  • I usually have all the QuickLook plugins available installed
  • Everything installed to: E:\Program Files\pf(x64)\Everything
  • Background programs: Greenshot, TidyTabs, Panda Antivirus, 7+ Taskbar Numberer, Stardock Fences, IDM, Virtual CloneDrive
  • Drivers: Nvidia, Intel Integrated graphics, Intel RST, Mad Catz R.A.T, Epson ET2550 Printer, Waves MaxxAudioPro

EDIT2: I just had a think, and tried closing TidyTabs (only other program I could think would access file paths in the background like this). Tested a couple times, all good. Will test more, but I suspect TidyTabs. Do you use it, @HASJ?

@HASJ
Copy link

HASJ commented Apr 12, 2020

@HASJ What activation key combo do you use for QuickLook? (Off topic, but how did you get QuickLook dark like that?! Looks sweet!)

CTRL + Shift + F. Custom Windows theme named Penumbra, you can get it on DeviantArt.

@HASJ, what programs do you normally keep running as services & where do you have QuickLook/Everything installed? Maybe there's a common denominator for us.

Default locations and as of v3.6.7, QuickLook only copies the file's path when previewing a file, like xupefei said.
I don't use TidyTabs, no. My issue seems fixed.

@Darthagnon
Copy link
Author

I'm thinking my issue must have been caused by having a Quicklook window open (and hidden) in the background somewhere (which can sometimes happen, when the user forgets about it, or doesn't dismiss it, or "pins" a Quicklook window). Upon searching Everything and navigating with the arrow keys to the target file, Quicklook would update with previews of the highlighted files, but in the background, out of sight. This would result in the clipboard being overwritten, without any prompt.

Workaround: I need to make sure to dismiss Quicklook windows, so they don't stay open in the background and overwrite my clipboard.

@xupefei
Copy link
Member

xupefei commented May 28, 2020

This is certainly possible, and is the reason why macOS Quick Look window will always be on top of any other windows.

@K0media
Copy link

K0media commented Apr 5, 2021

image
@Darthagnon @N3PP I found the issue. If you mark Everything > Tools > General > Results > Double quote copy as path as on, QuickLook can't use the path.
Clipboard is still being overwritten, however.

Not related to this issue (completely), but where did you get dark theme for Everything? You did those workaround they're showing in forums or it has been finally rolled out? If it's rolled out, I have to update my build.

Thanks.

(Sorry for OT, just a quick question.)

@Darthagnon
Copy link
Author

@K0media Penumbra theme on DeviantArt, requires UltraUXThemePatcher, will make all of Windows nice and dark.

@albino1
Copy link

albino1 commented Apr 6, 2021

@K0media, for what it's worth a Dark Mode/Dark Theme is coming in the next big Everything 1.5 update. It looks like this and is customizable:

https://www.voidtools.com/forum/viewtopic.php?f=12&t=9789

You can try it out now in the Alpha release, though it's got some bugs:

https://www.voidtools.com/forum/viewtopic.php?f=12&t=9787

@Darthagnon
Copy link
Author

Glad to hear the news about an Everything Dark Mode. Looks like it's getting some other sick improvements, too!


It's also worth noting that I haven't noticed the titular bug with folder path copying for quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants