Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Python 3.8 FFI support #704

Closed
Alexander-N opened this issue Dec 28, 2019 · 5 comments · Fixed by #784
Closed

Full Python 3.8 FFI support #704

Alexander-N opened this issue Dec 28, 2019 · 5 comments · Fixed by #784
Labels
CI Continuous Integration FFI
Milestone

Comments

@Alexander-N
Copy link
Member

Alexander-N commented Dec 28, 2019

I think dgrunwald/rust-cpython#187 does provide a good starting point for us.

3.8 should also be added to CI. There was some issue when I tried to replace 3.8-dev with 3.8 in #648

Edit: Removed unrelated issue.

@kngwyu
Copy link
Member

kngwyu commented Dec 28, 2019

I wrote some patches on Python3.8 and observed no test failing...
But yeah, now it's time to check FFI compatiblitity and add it to CI.

@kngwyu kngwyu added the FFI label Dec 28, 2019
@Alexander-N
Copy link
Member Author

With github actions I get the same error as with travis:

AttributeError: module 'os' has no attribute 'link'

from https://github.com/PyO3/pyo3/runs/365982476

@kngwyu kngwyu added the CI Continuous Integration label Dec 28, 2019
@kngwyu
Copy link
Member

kngwyu commented Dec 28, 2019

With github actions I get the same error as with travis:
AttributeError: module 'os' has no attribute 'link'

I saw the same error when I set up Python3.8 CI on Azure for a personal project, and ... I still don't know the solution! 😓

@davidhewitt
Copy link
Member

Now that we have 3.8 on CI, what else are we wanting to add here? (Presumably all new C APIs added in Python 3.8?)

@Alexander-N
Copy link
Member Author

Now that we have 3.8 on CI, what else are we wanting to add here? (Presumably all new C APIs added in Python 3.8?)

This and I would say checking that all changes in the c-api are accounted for. For example in dgrunwald/rust-cpython#187 there was a #[cfg(all(Py_3_5, not(Py_3_8)))] added on PyTypeObject_INIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration FFI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants