Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken by TryFrom on latest nightly #136

Closed
konstin opened this issue Mar 29, 2018 · 2 comments
Closed

Build broken by TryFrom on latest nightly #136

konstin opened this issue Mar 29, 2018 · 2 comments

Comments

@konstin
Copy link
Member

konstin commented Mar 29, 2018

With the latest nightly, the build fails with a bunch of errors in TryFrom like the following one.

note: candidate #1 is defined in an impl of the trait `conversion::PyTryFrom` for the type `objects::sequence::PySequence`
   --> pyo3/src/objects/sequence.rs:252:5
    |
252 |     fn try_from(value: &PyObjectRef) -> Result<&PySequence, Self::Error> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: candidate #2 is defined in an impl of the trait `std::convert::TryFrom` for the type `_`

error[E0034]: multiple applicable items in scope
  --> pyo3/src/objects/stringutils.rs:60:9
   |
60 |         PyString::try_from(ob)?.to_string()
   |         ^^^^^^^^^^^^^^^^^^ multiple `try_from` found
   |

This is most likely caused by the stabilization of TryFrom in rust-lang/rust#49305

@fafhrd91
Copy link
Contributor

fixes by #137

@konstin
Copy link
Member Author

konstin commented Mar 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants