Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce number of imports? #795

Open
rpruim opened this issue Feb 28, 2022 · 3 comments
Open

reduce number of imports? #795

rpruim opened this issue Feb 28, 2022 · 3 comments

Comments

@rpruim
Copy link
Contributor

rpruim commented Feb 28, 2022

Checking the package gives the following message:

> checking package dependencies ... NOTE
  Imports includes 21 non-default packages.
  Importing from so many packages makes the package vulnerable to any of
  them becoming unavailable.  Move as many as possible to Suggests and
  use conditionally.

If we can reduce the dependency tree, that is probably good for any number of reasons.

@nicholasjhorton
Copy link
Contributor

I concur.

Is this just the "Imports" list (20 at present based on my count for the 1.8.3 version on CRAN)?

@rpruim
Copy link
Contributor Author

rpruim commented Feb 28, 2022

Just imports. I added {purrr} earlier today to hit 21. But I may be removing {purrr} in favor of a different solution to #779

@rpruim
Copy link
Contributor Author

rpruim commented Feb 28, 2022

I'm going through the imports to find packages used only in isolated corners of mosaic. For those, I'll likely use rlang::check_installed() before any uses of the package. That will prompt the user to install the package if it is not and quit execution if they choose not to install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants