Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting prerender: false creates two closing </head> tags in a template with a <style> tag #859

Closed
1 of 5 tasks
thescientist13 opened this issue Jan 12, 2022 · 0 comments · Fixed by #862
Closed
1 of 5 tasks

setting prerender: false creates two closing </head> tags in a template with a <style> tag #859

thescientist13 opened this issue Jan 12, 2022 · 0 comments · Fixed by #862
Assignees
@thescientist13
Labels
bug Something isn't working CLI v0.22.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Jan 12, 2022 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

As part of working on #855 , I noticed that the Default Greenwood Configuration and Workspace w/Custom Page Template specs were failing due to an error in the smoke test of mismatching <head> tags.

  2) Running Common Index Smoke Tests for Default Greenwood Configuration and Workspace w/Custom Page Template
       document <head>
         should have matching opening and closing <head> tags in the <head>:

      AssertionError: expected false to equal true
      + expected - actual

      -false
      +true

Details

Seems similar to #810 and something about the proximity / usage of a <style> tag? Here is that the final generated HTML looks like

<!DOCTYPE html>
  <html lang="en" prefix="og:http://ogp.me/ns#">



  <head>
    <link rel="preload" href="/styles/theme.16214223.css" as="style" crossorigin="anonymous">
    </link>

    <link rel="modulepreload" href="/main.afc4433b.js" as="script">




    <title>My App</title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <meta name="mobile-web-app-capable" content="yes" />
    <meta name="apple-mobile-web-app-capable" content="yes" />
    <meta name="apple-mobile-web-app-status-bar-style" content="black" />

    <meta property="og:description" content="My custom meta content." />



    <script type="module" src="/main.afc4433b.js"></script>

    <link rel="stylesheet" href="/styles/theme.16214223.css" />
  </head>
  <style>
    .owen-test {
      color: blue;
    }

    h3 {
      color: green;
    }
  </style>
  </head>




  <body>


    <div class='wrapper'>
      <div class='page-template content owen-test'>
        <h3>Hello</h3>

        <h1>Welcome to Greenwood!</h1>

      </div>
    </div>


  </body>

</html>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI v0.22.0
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

handle puppeteer fixing our invalid HTML ProjectEvergreen/greenwood
1 participant
@thescientist13