From 6d26fd6d42e21f629230ad499368676e250bda36 Mon Sep 17 00:00:00 2001
From: "b.endres" <endres@systopia.de>
Date: Mon, 12 Aug 2024 20:28:28 +0200
Subject: [PATCH 1/4] @vurt2's proposal for #50

---
 templates/CRM/Bic/Page/BicList.tpl | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/templates/CRM/Bic/Page/BicList.tpl b/templates/CRM/Bic/Page/BicList.tpl
index 6cee03d..11df65e 100644
--- a/templates/CRM/Bic/Page/BicList.tpl
+++ b/templates/CRM/Bic/Page/BicList.tpl
@@ -69,7 +69,7 @@
 {foreach from=$countries item=country}
           <option value="{$country}" {if $country eq $default_country}selected{/if}>{$country_names.$country}</option>
 {/foreach}
-        </select>      
+        </select>
       </td>
       <td><input type="text" value="" name="nbid" id="nbid"></td>
       <td><input type="text" value="" name="bic" id="bic" style="text-transform:uppercase;"></td>
@@ -98,13 +98,13 @@
 <script type="text/javascript">
   // Empty fields when loading the page
   cleanFilters();
-  
+
   // Perform a search when a field changes
   cj("#country").change(sendQuery);
   cj("#bic").change(sendQuery);
   cj("#nbid").change(sendQuery);
   cj("#iban").change(sendIBANQuery);
-  
+
   // Empty BIC when writting NBID and viceversa
   cj("#bic").keyup(enteringBIC);
   cj("#nbid").keyup(enteringNBID);
@@ -116,7 +116,7 @@
     query['bic'] = cj("#bic").val();
     query['nbid'] = cj("#nbid").val();
     query['country'] = cj("#country").val();
-    
+
     CRM.api3('Bic', 'get', query).done(
       function(result) {
         if (result.count > 0 ) {
@@ -130,15 +130,15 @@
                         "<td>" + result.values[key].country + "</td>" +
                         "<td>" + result.values[key].nbid + "</td>" +
                       "</tr>";
-                      
+
             if (rowstyle == 'odd-row') { rowstyle = 'even-row'; } else { rowstyle = 'odd-row'; }
           }
-          
+
           cj("#results").empty();
           cj("#results").append(line);
-          
+
         } else {
-          var line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href='bicImport'>update your bank list</a>.</td></tr>";
+          var line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href="/civicrm/bicImport">update your bank list</a>.</td></tr>";
           cj("#results").empty();
           cj("#results").append(line);
         }
@@ -155,7 +155,7 @@
     query['iban'] = query['iban'].replace(reSpaceAndMinus, "");
     query['iban'] = query['iban'].toUpperCase();
 
-    
+
     CRM.api3('Bic', 'findbyiban', query).done(
       function(result) {
         if (result.count != 0 ) {
@@ -166,10 +166,10 @@
                       "<td>" + result.country + "</td>" +
                       "<td>" + result.nbid + "</td>" +
                     "</tr>";
-          
+
           cj("#iban_results").empty();
           cj("#iban_results").append(line);
-          
+
         } else {
           var line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href='bicImport'>update your bank list</a>.</td></tr>";
           cj("#iban_results").empty();
@@ -192,7 +192,7 @@
       sendQuery();
     }
   }
-  
+
   function enteringIBAN() {
     if(cj("#iban").val().length >= 10) {
       sendIBANQuery();
@@ -205,4 +205,4 @@
   }
 </script>
 {/literal}
-{/crmScope}
\ No newline at end of file
+{/crmScope}

From a3029b00d39e072f0b5961b2ab4d873988f9d0d1 Mon Sep 17 00:00:00 2001
From: "b.endres" <endres@systopia.de>
Date: Mon, 12 Aug 2024 20:32:12 +0200
Subject: [PATCH 2/4] second occurrence

---
 templates/CRM/Bic/Page/BicList.tpl | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/templates/CRM/Bic/Page/BicList.tpl b/templates/CRM/Bic/Page/BicList.tpl
index 11df65e..f1f7064 100644
--- a/templates/CRM/Bic/Page/BicList.tpl
+++ b/templates/CRM/Bic/Page/BicList.tpl
@@ -14,7 +14,7 @@
 
 {crmScope extensionKey='org.project60.bic'}
 {if $show_message}
-  <div id="help">{ts}This page allows you to find banks and additional information. If you can't find the bank you're looking for, you may want to <a href='bicImport'>update your bank list</a>.{/ts}</div>
+  <div id="help">{ts}This page allows you to find banks and additional information. If you can't find the bank you're looking for, you may want to <a href="/civicrm/bicImport">update your bank list</a>.{/ts}</div>
 {/if}
 
 
@@ -171,7 +171,6 @@
           cj("#iban_results").append(line);
 
         } else {
-          var line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href='bicImport'>update your bank list</a>.</td></tr>";
           cj("#iban_results").empty();
           cj("#iban_results").append(line);
         }

From bca40a0341fe6f13425a242e6ac55375c80dfd3d Mon Sep 17 00:00:00 2001
From: "b.endres" <endres@systopia.de>
Date: Mon, 12 Aug 2024 20:40:46 +0200
Subject: [PATCH 3/4] fixing nested quotes

---
 templates/CRM/Bic/Page/BicList.tpl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/templates/CRM/Bic/Page/BicList.tpl b/templates/CRM/Bic/Page/BicList.tpl
index f1f7064..6ee6f1a 100644
--- a/templates/CRM/Bic/Page/BicList.tpl
+++ b/templates/CRM/Bic/Page/BicList.tpl
@@ -14,7 +14,7 @@
 
 {crmScope extensionKey='org.project60.bic'}
 {if $show_message}
-  <div id="help">{ts}This page allows you to find banks and additional information. If you can't find the bank you're looking for, you may want to <a href="/civicrm/bicImport">update your bank list</a>.{/ts}</div>
+  <div id="help">{ts}This page allows you to find banks and additional information. If you can't find the bank you're looking for, you may want to <a href='/civicrm/bicImport'>update your bank list</a>.{/ts}</div>
 {/if}
 
 
@@ -138,7 +138,7 @@
           cj("#results").append(line);
 
         } else {
-          var line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href="/civicrm/bicImport">update your bank list</a>.</td></tr>";
+          var line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href='/civicrm/bicImport'>update your bank list</a>.</td></tr>";
           cj("#results").empty();
           cj("#results").append(line);
         }
@@ -171,6 +171,7 @@
           cj("#iban_results").append(line);
 
         } else {
+          let line = "<tr class='odd-row'><td colspan='5'>Could not find any match with this criteria. You may want to <a href='/civicrm/bicImport'>update your bank list</a>.</td></tr>";
           cj("#iban_results").empty();
           cj("#iban_results").append(line);
         }

From d21d5df0096334f27562bc1b2c0b0181b9cd5eaa Mon Sep 17 00:00:00 2001
From: "b.endres" <endres@systopia.de>
Date: Tue, 13 Aug 2024 20:39:31 +0200
Subject: [PATCH 4/4] added url prefix to bicList page, too

---
 templates/CRM/Bic/Page/Config.tpl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/templates/CRM/Bic/Page/Config.tpl b/templates/CRM/Bic/Page/Config.tpl
index 92f37bc..4604e20 100644
--- a/templates/CRM/Bic/Page/Config.tpl
+++ b/templates/CRM/Bic/Page/Config.tpl
@@ -17,7 +17,7 @@
   If you click the Update button, next to the name of one of the listed countries,
   CiviCRM will try to connect to the official source of financial institutions
   in this country and retrieve its bank information. Then, you'll be able to
-  query this information in the <a href="bicList">Banks List</a> page.
+  query this information in the <a href="/civicrm/bicList">Banks List</a> page.
 {/ts}</div>
 
 {* TODO: make this more beatiful ;) *}
@@ -77,7 +77,7 @@
 <script type="text/javascript">
   cj("#printer-friendly").hide();
   cj("#access").hide();
-  
+
   cj().crmAccordions();
 
   // UPDATE BUTTONS
@@ -88,7 +88,7 @@
 
     // disable buttons
     cj('.button').addClass('disabled');
-    
+
     if (country_code=='all') {
       // set ALL to busy
       cj(button).parent().parent().parent().parent().parent().find('[name="busy"]').show();
@@ -131,4 +131,4 @@
   }
 </script>
 {/literal}
-{/crmScope}
\ No newline at end of file
+{/crmScope}