-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on PHP 8.0 #456
Run CI on PHP 8.0 #456
Conversation
📝 WalkthroughWalkthroughThe pull request updates the CI workflow configuration by modifying the PHP version specified in the job matrix for MediaWiki version "REL1_39." The PHP version is changed from 8.1 to 8.0 in the workflow file, which affects the environment setup for testing that MediaWiki version. Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
17-19
: PHP Version Downgrade formw: 'REL1_39'
—Ensure CompatibilityThe CI workflow now sets PHP to 8.0 for MediaWiki
REL1_39
(line 18) per the CI objective. Please verify that:
- MediaWiki REL1_39 and all its dependencies are fully compatible with PHP 8.0.
- This downgrade does not inadvertently cause test failures or compatibility issues, especially since the other matrix entries use later PHP versions.
If further changes or documentation updates are needed to clarify the rationale for this isolated version change, please address those accordingly.
Summary by CodeRabbit