Remove FontAwesome

[malberts]

Instead of maintaining a copy of FontAwesome in Chameleon, rather remove it and have an optional dependency on Extension:FontAwesome.

Chameleon can still define default icons and additonal FontAwesome-specific styling, but that will only be used if Extension:FontAwesome is enabled.

This will likely only be implemented along with the upgrade to Boostrap 5.3 (#385).

[JeroenDeDauw]

Would that mean that all these icons disappear unless you install the FA extension?

[malberts]

Yes. The user menu icon will probably need some special attention (maybe using a Codex icon, don't know).

[WouterRademaker]

This is what is roughly required for a hard dependency:

/skins/chameleon/src/Hooks/SetupAfterCache.php

--- SetupAfterCache.php.orig	2025-02-21 14:54:49.000000000 +0100
+++ SetupAfterCache.php	2025-02-25 20:29:22.812229481 +0100
@@ -69,6 +69,8 @@
 	protected function setInstallPaths(): void {
 		$GLOBALS[ 'chameleonLocalPath' ] = $this->configuration['wgStyleDirectory'] . '/chameleon';
 		$GLOBALS[ 'chameleonRemotePath' ] = $this->configuration['wgStylePath'] . '/chameleon';
+		$GLOBALS[ 'fontawesomeLocalPath' ] = $this->configuration['wgExtensionDirectory'] . '/FontAwesome';
+		$GLOBALS[ 'fontawesomeRemotePath' ] = $this->configuration['wgExtensionAssetsPath'] . '/FontAwesome';
 	}
 
 	protected function addLateSettings() {
@@ -92,25 +94,25 @@
 			);
 		}
 
 
 		$this->bootstrapManager->addStyleFile(
-			$GLOBALS[ 'chameleonLocalPath' ] . '/resources/fontawesome/scss/fontawesome.scss'
+			$GLOBALS[ 'fontawesomeLocalPath' ] . '/res/fontawesome/scss/fontawesome.scss'
 		);
 
 		$this->bootstrapManager->addStyleFile(
-			$GLOBALS[ 'chameleonLocalPath' ] . 	'/resources/fontawesome/scss/fa-solid.scss'
+			$GLOBALS[ 'fontawesomeLocalPath' ] . '/res/fontawesome/scss/solid.scss'
 		);
 
 		$this->bootstrapManager->addStyleFile(
-			$GLOBALS[ 'chameleonLocalPath' ] . '/resources/fontawesome/scss/fa-regular.scss'
+			$GLOBALS[ 'fontawesomeLocalPath' ] . '/res/fontawesome/scss/regular.scss'
 		);
 
 		$this->bootstrapManager->addStyleFile(
-			$GLOBALS[ 'chameleonLocalPath' ] . '/resources/fontawesome/scss/fa-brands.scss'
+			$GLOBALS[ 'fontawesomeLocalPath' ] . '/res/fontawesome/scss/brands.scss'
 		);
 
 		$this->bootstrapManager->addStyleFile(
@@ -115,8 +117,9 @@
 
 		$this->bootstrapManager->setScssVariable(
 			'fa-font-path',
-			$GLOBALS[ 'chameleonRemotePath' ] . '/resources/fontawesome/webfonts'
+			$GLOBALS[ 'fontawesomeRemotePath' ] . '/res/fontawesome/webfonts'
 		);
 	}

/skins/chameleon/resources/styles/_fixes.scss

--- _fixes.scss.orig	2025-02-21 14:54:49.000000000 +0100
+++ _fixes.scss	2025-02-25 19:25:29.394663736 +0100
@@ -29,18 +29,18 @@
 
 .fa, .fas {
 	&:before {
-		font-family: 'Font Awesome 5 Free';
+		font-family: 'Font Awesome 6 Free';
 		font-weight: 900;
 	}
 }
 
 .far:before {
-	font-family: 'Font Awesome 5 Free';
+	font-family: 'Font Awesome 6 Free';
 	font-weight: 400;
 }
 
 .fab:before {
-	font-family: 'Font Awesome 5 Brands';
+	font-family: 'Font Awesome 6 Brands';
 }
 
 // When there is a "small" in the hierarchy, we mean it

[WouterRademaker]

Font Awesome 5 from chameleon skin:

Font Awesome 6 from Font Awesome extension:

[WouterRademaker]

Also needed is a small change in /extensions/FontAwesome/package.json and the build scripts run:

--- package.json.orig	2025-02-10 12:16:11.405823626 +0100
+++ package.json	2025-02-25 22:33:08.917649227 +0100
@@ -1,7 +1,7 @@
 {
   "scripts": {
     "prebuild": "npm install",
-    "build:fontawesome": "bash -c \"if [ -d res/fontawesome ]; then rm -rf res/fontawesome; fi && mkdir -p res/fontawesome && cp -R node_modules/@fortawesome/fontawesome-free/{css,js,webfonts,LICENSE.txt} res/fontawesome\"",
+    "build:fontawesome": "bash -c \"if [ -d res/fontawesome ]; then rm -rf res/fontawesome; fi && mkdir -p res/fontawesome && cp -R node_modules/@fortawesome/fontawesome-free/{css,js,scss,webfonts,LICENSE.txt} res/fontawesome\"",
     "build": "npm run build:fontawesome"
   },
   "devDependencies": {

So the second image in my previous comment is with the most recent Font Awesome version: Release 6.7.2