Add makeFooterIcon() wrapper

ProfessionalWiki · Feb 21, 2025 · f2879b3 · f2879b3
1 parent f33f39b
commit f2879b3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/ChameleonTemplate.php b/src/ChameleonTemplate.php
@@ -157,4 +157,9 @@ public function getFooterIconsWithImage() {
 
 		return $footericons;
 	}
+
+	public function makeFooterIcon( string|array $icon ): string {
+		return $this->getSkin()->makeFooterIcon( $icon );
+	}
+
 }
diff --git a/src/Components/FooterIcons.php b/src/Components/FooterIcons.php
@@ -71,7 +71,7 @@ private function getIcons() {
 
 			foreach ( $footerIcons as $icon ) {
 				$lines[] = $this->indent() . '<div>' .
-					$this->getSkinTemplate()->getSkin()->makeFooterIcon( $icon ) . '</div>';
+					$this->getSkinTemplate()->makeFooterIcon( $icon ) . '</div>';
 			}
 
 		}

diff --git a/tests/phpunit/Unit/Components/FooterIconsTest.php b/tests/phpunit/Unit/Components/FooterIconsTest.php
@@ -47,17 +47,15 @@ class FooterIconsTest extends GenericComponentTestCase {
 	public function testGetHtml() {
 		$chameleonTemplate = $this->getChameleonSkinTemplateStub();
 
-		$skin = $chameleonTemplate->getSkin();
-
-		$skin->expects( $this->exactly( 4 ) )
+		$chameleonTemplate->expects( $this->exactly( 4 ) )
 			->method( 'makeFooterIcon' )
 			->withConsecutive(
 				[ $this->equalTo( 'icon1' ) ],
 				[ $this->equalTo( 'icon2' ) ],
 				[ $this->equalTo( 'icon3' ) ],
 				[ $this->equalTo( 'icon4' ) ]
 			)
-			->willReturn( $this->returnValue( 'SomeHTML' ) );
+			->willReturn( 'SomeHTML' );
 
 		$chameleonTemplate->expects( $this->any() )
 			->method( 'getFooterIconsWithImage' )