Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [SECURITY] [CRITICAL] Moq should be replaced with something less parasitic #2923

Closed
thoys opened this issue Aug 9, 2023 · 4 comments
Closed

Comments

@thoys
Copy link

thoys commented Aug 9, 2023

Description

You're using a library that spawns git processes and forwards the email addresses it finds in the repositories to the repo owner. Please have a look at the following issue:

https://github.com/moq/moq/issues/1372

Steps to Reproduce

Platform with bug

Prism Core

Affected platforms

iOS, Android, Windows, macOS

Did you find any workaround?

Downloading the project stripping it from All Moq and just skipping the testing until there is a decent replacement.

Relevant log output

No response

@brianlagunas
Copy link
Member

brianlagunas commented Aug 9, 2023

We use v4.18.4 so we are good. This change has been reverted with this PR: https://github.com/moq/moq/pull/1375

The project maintainer has started a discussion around his intent and possible other ways to accomplish his goals: https://github.com/moq/moq/issues/1374

However, this does point to some potential loss of trust. The Prism team will discuss and decide on what action we should take if any.

Also, I don't use my real email with Git 😄

Thank you for raising this important issue.

@thoys
Copy link
Author

thoys commented Aug 9, 2023

Thanks, just trying to keep you guys safe. I've been using this library for a while now and try to contribute where I can.

@dansiegel
Copy link
Member

Let's be clear the dependency on Moq even if we used the now unlisted 4.20.0 would not affect Prism users as the dependency is a testing dependency not a dependency which you get because you have a dependency on Prism.

@kzu
Copy link

kzu commented Aug 9, 2023

Thanks @dansiegel for clarifying this for users. Perhaps it's something that isn't sufficiently clearly documented in https://github.com/devlooped/SponsorLink?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants