bug: If property doesn't exist on object, don't throw KeyNotFoundException #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption The spec says to check if the descriptor is undefined when calling OrdinaryGet. Before this commit, we always tried to get the property from the internal dictionary. This would cause internal errors, throwing a KeyNotFoundException if the property did not exist on the object.
6a72279 to
5f0a8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says to check if the descriptor is undefined when calling OrdinaryGet. Before this commit, we always tried to get the property from the internal dictionary.
This would cause internal errors, throwing a KeyNotFoundException if the property did not exist on the object.