Support the undefined property of the GlobalObject #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a property named "undefined" with the value of undefined as defined in the spec.
In some places in the spec, a function returns a Property Descriptor or undefined (etc.). So for this behaviour we use
The spec wants us to return a property descriptor not the actual value. This allows support for undefined being resolved to work. Before, when getting an undefined property value from object, we'd check if a value was undefined and if it was we returned that the property doesn't exist. Now we can have properties that are defined but have a value of undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support the undefined property on the GlobalObject.
This allows the value of undefined to be used within our AST.
For example:
is now supported