chore: Use global usings for overiding default C# types with our own

We use types like "Boolean" and "String" for our JS values, however, these are default C# types. However, we don't use String or Boolean (etc.) so we default override them with global usings.
PrestonLTaylor · Apr 5, 2024 · d4a0794 · d4a0794
1 parent 6154bd4
commit d4a0794
Show file tree

Hide file tree

Showing 36 changed files with 14 additions and 58 deletions.
diff --git a/JSS.Lib.UnitTests/ASTTests.cs b/JSS.Lib.UnitTests/ASTTests.cs
@@ -1,10 +1,6 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.AST.Literal;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
-using Object = JSS.Lib.AST.Values.Object;
-using String = JSS.Lib.AST.Values.String;
-using ValueType = JSS.Lib.AST.Values.ValueType;
 using JSS.Lib.AST;
 using FluentAssertions;
 

diff --git a/JSS.Lib.UnitTests/AbstractOperationTests.cs b/JSS.Lib.UnitTests/AbstractOperationTests.cs
@@ -3,8 +3,6 @@
 using JSS.Lib.AST.Literal;
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
-using String = JSS.Lib.AST.Values.String;
 
 namespace JSS.Lib.UnitTests;
 

diff --git a/JSS.Lib.UnitTests/Usings.cs b/JSS.Lib.UnitTests/Usings.cs
@@ -1 +1,5 @@
-global using NUnit.Framework;
+global using NUnit.Framework;
+global using Boolean = JSS.Lib.AST.Values.Boolean;
+global using Object = JSS.Lib.AST.Values.Object;
+global using String = JSS.Lib.AST.Values.String;
+global using ValueType = JSS.Lib.AST.Values.ValueType;
diff --git a/JSS.Lib/AST/Block.cs b/JSS.Lib/AST/Block.cs
@@ -1,5 +1,4 @@
 using JSS.Lib.Execution;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/CallExpression.cs b/JSS.Lib/AST/CallExpression.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using String = JSS.Lib.AST.Values.String;
-using Object = JSS.Lib.AST.Values.Object;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/ConstDeclaration.cs b/JSS.Lib/AST/ConstDeclaration.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/FunctionDeclaration.cs b/JSS.Lib/AST/FunctionDeclaration.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Environment = JSS.Lib.Execution.Environment;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/GreaterThanEqualsExpression.cs b/JSS.Lib/AST/GreaterThanEqualsExpression.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/GreaterThanExpreesion.cs b/JSS.Lib/AST/GreaterThanExpreesion.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/IExpression.cs b/JSS.Lib/AST/IExpression.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using String = JSS.Lib.AST.Values.String;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/InExpression.cs b/JSS.Lib/AST/InExpression.cs
@@ -1,6 +1,4 @@
 using JSS.Lib.Execution;
-using Object = JSS.Lib.AST.Values.Object;
-using String = JSS.Lib.AST.Values.String;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/LessThanEqualsExpression.cs b/JSS.Lib/AST/LessThanEqualsExpression.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/LessThanExpression.cs b/JSS.Lib/AST/LessThanExpression.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/LetDeclaration.cs b/JSS.Lib/AST/LetDeclaration.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/Literal/BooleanLiteral.cs b/JSS.Lib/AST/Literal/BooleanLiteral.cs
@@ -1,5 +1,4 @@
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST.Literal;
 

diff --git a/JSS.Lib/AST/Literal/ObjectLiteral.cs b/JSS.Lib/AST/Literal/ObjectLiteral.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.Execution;
 using JSS.Lib.Runtime;
-using Object = JSS.Lib.AST.Values.Object;
 
 namespace JSS.Lib.AST.Literal;
 

diff --git a/JSS.Lib/AST/Literal/StringLiteral.cs b/JSS.Lib/AST/Literal/StringLiteral.cs
@@ -1,5 +1,4 @@
 using JSS.Lib.Execution;
-using String = JSS.Lib.AST.Values.String;
 
 namespace JSS.Lib.AST.Literal;
 

diff --git a/JSS.Lib/AST/LogicalNotExpression.cs b/JSS.Lib/AST/LogicalNotExpression.cs
@@ -1,5 +1,4 @@
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/LooseInequalityExpression.cs b/JSS.Lib/AST/LooseInequalityExpression.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/NewExpression.cs b/JSS.Lib/AST/NewExpression.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using String = JSS.Lib.AST.Values.String;
-
 namespace JSS.Lib.AST;
 
 // 13.3.5 The new Operator, https://tc39.es/ecma262/#sec-new-operator

diff --git a/JSS.Lib/AST/StrictInequalityExpression.cs b/JSS.Lib/AST/StrictInequalityExpression.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.AST;
 

diff --git a/JSS.Lib/AST/TypeOfExpression.cs b/JSS.Lib/AST/TypeOfExpression.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.Execution;
 using JSS.Lib.AST.Values;
-using String = JSS.Lib.AST.Values.String;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 using System.Diagnostics;
 
 namespace JSS.Lib.AST;

diff --git a/JSS.Lib/AST/Values/FunctionObject.cs b/JSS.Lib/AST/Values/FunctionObject.cs
@@ -1,9 +1,6 @@
 using JSS.Lib.Execution;
 using JSS.Lib.Runtime;
 using System.Diagnostics;
-using Environment = JSS.Lib.Execution.Environment;
-using ExecutionContext = JSS.Lib.Execution.ExecutionContext;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.AST.Values;
 

diff --git a/JSS.Lib/AST/Values/Value.cs b/JSS.Lib/AST/Values/Value.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.Execution;
 using System.Diagnostics;
-using Environment = JSS.Lib.Execution.Environment;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.AST.Values;
 

diff --git a/JSS.Lib/Execution/Completion.cs b/JSS.Lib/Execution/Completion.cs
@@ -1,6 +1,5 @@
 using JSS.Lib.AST.Values;
 using System.Diagnostics;
-using Boolean = JSS.Lib.AST.Values.Boolean;
 
 namespace JSS.Lib.Execution;
 

diff --git a/JSS.Lib/Execution/DeclarativeEnvironment.cs b/JSS.Lib/Execution/DeclarativeEnvironment.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.AST.Values;
 using System.Diagnostics;
-using String = JSS.Lib.AST.Values.String;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.Execution;
 

diff --git a/JSS.Lib/Execution/Environment.cs b/JSS.Lib/Execution/Environment.cs
@@ -1,5 +1,4 @@
 using JSS.Lib.AST.Values;
-using ValueType = JSS.Lib.AST.Values.ValueType;
 
 namespace JSS.Lib.Execution;
 

diff --git a/JSS.Lib/Execution/FunctionEnvironment.cs b/JSS.Lib/Execution/FunctionEnvironment.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.AST.Values;
 using System.Diagnostics;
-using String = JSS.Lib.AST.Values.String;
-using Object = JSS.Lib.AST.Values.Object;
 
 namespace JSS.Lib.Execution;
 

diff --git a/JSS.Lib/Execution/GlobalEnvironment.cs b/JSS.Lib/Execution/GlobalEnvironment.cs
@@ -1,9 +1,5 @@
 using JSS.Lib.AST.Values;
 using System.Diagnostics;
-using Boolean = JSS.Lib.AST.Values.Boolean;
-using String = JSS.Lib.AST.Values.String;
-using Object = JSS.Lib.AST.Values.Object;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.Execution;
 

diff --git a/JSS.Lib/Execution/ObjectEnvironment.cs b/JSS.Lib/Execution/ObjectEnvironment.cs
@@ -1,8 +1,4 @@
 using JSS.Lib.AST.Values;
-using Boolean = JSS.Lib.AST.Values.Boolean;
-using Object = JSS.Lib.AST.Values.Object;
-using String = JSS.Lib.AST.Values.String;
-
 namespace JSS.Lib.Execution;
 
 internal sealed class ObjectEnvironment : Environment

diff --git a/JSS.Lib/Execution/Realm.cs b/JSS.Lib/Execution/Realm.cs
@@ -1,7 +1,6 @@
 using System.Diagnostics;
 using JSS.Lib.AST.Values;
 using JSS.Lib.Runtime;
-using Object = JSS.Lib.AST.Values.Object;
 
 namespace JSS.Lib.Execution;
 

diff --git a/JSS.Lib/Execution/Script.cs b/JSS.Lib/Execution/Script.cs
@@ -1,7 +1,5 @@
-using Boolean = JSS.Lib.AST.Values.Boolean;
-using JSS.Lib.AST.Values;
+using JSS.Lib.AST.Values;
 using JSS.Lib.AST;
-using String = JSS.Lib.AST.Values.String;
 using System.Diagnostics;
 
 namespace JSS.Lib.Execution;

diff --git a/JSS.Lib/Runtime/Object.constructor.cs b/JSS.Lib/Runtime/Object.constructor.cs
@@ -1,7 +1,5 @@
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Object = JSS.Lib.AST.Values.Object;
-using static JSS.Lib.Execution.CompletionHelper;
 
 namespace JSS.Lib.Runtime;
 

diff --git a/JSS.Lib/Runtime/Object.prototype.cs b/JSS.Lib/Runtime/Object.prototype.cs
@@ -1,5 +1,4 @@
 using JSS.Lib.AST.Values;
-using Object = JSS.Lib.AST.Values.Object;
 
 namespace JSS.Lib.Runtime;
 

diff --git a/JSS.Lib/Usings.cs b/JSS.Lib/Usings.cs
@@ -0,0 +1,8 @@
+global using Boolean = JSS.Lib.AST.Values.Boolean; 
+global using Environment = JSS.Lib.Execution.Environment;
+global using ExecutionContext = JSS.Lib.Execution.ExecutionContext;
+global using Object = JSS.Lib.AST.Values.Object;
+global using String = JSS.Lib.AST.Values.String; 
+global using ValueType = JSS.Lib.AST.Values.ValueType;
+
+global using static JSS.Lib.Execution.CompletionHelper;
diff --git a/JSS/Print.cs b/JSS/Print.cs
@@ -1,8 +1,6 @@
 using JSS.Lib;
 using JSS.Lib.AST.Values;
 using JSS.Lib.Execution;
-using Boolean = JSS.Lib.AST.Values.Boolean;
-using String = JSS.Lib.AST.Values.String;
 
 namespace JSS.CLI;