Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

konsave command not found #11

Closed
t3kg33k opened this issue Mar 3, 2021 · 20 comments
Closed

konsave command not found #11

t3kg33k opened this issue Mar 3, 2021 · 20 comments

Comments

@t3kg33k
Copy link

t3kg33k commented Mar 3, 2021

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

The install did not work for me.

Selection_001

I noticed in your script that the utility is placed in the ~/.local/bin/ path. The reason that it didn't work for me is because my path is defined differently in my environment.

PATH=/usr/share/Modules/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/home/ed/bin

Maybe in your script you should either look at the user's PATH environment and place it in one of their defined paths or insert ./local/bin in the user's environment or something.
In the meantime, I will be adding that path to my .bashrc.

@t3kg33k
Copy link
Author

t3kg33k commented Mar 3, 2021

To add:
After adding the path to my .bashrc on my desktop I was able to run it, save a profile and export. I then attempted to install konsave on my laptop (both desktop and laptop running Fedora 33 with KDE Plasma) but the bin directory didn't even exist in ~/.local/ so I had to manually create it and then install konsave then add that path to my .bashrc. I was then able to import.
So, again, there may need to be some adjustments to your install script to query and make adjustments based on the user's PATH environment.

@selplacei
Copy link
Contributor

$HOME/.local/bin is expected to be in PATH on all XDG-compliant systems, and is the standard way to add an executable to a user's PATH. While it's not the responsibility of Konsave to change the user's .bashrc (especially since many people don't even use Bash), I agree that it would be nice to print as a message.

Also, if Konsave ever ends up on PyPI, it wouldn't need to manually create or link an executable in the first place.

@t3kg33k
Copy link
Author

t3kg33k commented Mar 3, 2021

$HOME/.local/bin is expected to be in PATH on all XDG-compliant systems, and is the standard way to add an executable to a user's PATH. While it's not the responsibility of Konsave to change the user's .bashrc (especially since many people don't even use Bash), I agree that it would be nice to print as a message.

Also, if Konsave ever ends up on PyPI, it wouldn't need to manually create or link an executable in the first place.

"...many people don't even use Bash"?
I'm confused by this statement. Who using Linux doesn't use Bash? I, and many, many others I know, use Bash on a daily basis.
Are you referring to the use of the Bash shell script to install the utility?

@selplacei
Copy link
Contributor

$HOME/.local/bin is expected to be in PATH on all XDG-compliant systems, and is the standard way to add an executable to a user's PATH. While it's not the responsibility of Konsave to change the user's .bashrc (especially since many people don't even use Bash), I agree that it would be nice to print as a message.
Also, if Konsave ever ends up on PyPI, it wouldn't need to manually create or link an executable in the first place.

"...many people don't even use Bash"?
I'm confused by this statement. Who using Linux doesn't use Bash? I, and many, many others I know, use Bash on a daily basis.
Are you referring to the use of the Bash shell script to install the utility?

I'm referring to other shells that use a different .rc file and ignore .bashrc (zsh, fish, etc.)

@Prayag2
Copy link
Owner

Prayag2 commented Mar 3, 2021

With so many bugs present, I think I did a mistake with the versioning. Should I change the version to alpha?

@Prayag2
Copy link
Owner

Prayag2 commented Mar 3, 2021

Also @selplacei, please look at this pull request and tell me your thoughts about it: #9

@selplacei
Copy link
Contributor

With so many bugs present, I think I did a mistake with the versioning. Should I change the version to alpha?

If you think that you've achieved the features you wanted so far, having a release is fine - bugfixes are released as patches. See semantic versioning for more info.

@selplacei
Copy link
Contributor

Also @selplacei, please look at this pull request and tell me your thoughts about it: #9

My version already has these features, so I'll leave it up to you to decide if you want them in your project. I'm here to fix things that I know how to fix.

@Prayag2
Copy link
Owner

Prayag2 commented Mar 3, 2021

Oh thanks

@Prayag2
Copy link
Owner

Prayag2 commented Mar 4, 2021

Should be fixed in the latest release

@Cabus1982
Copy link

`Dell% chmod +x ./install.sh

Dell% sudo ./install.sh
[sudo] password for cperon:

 _   ___  __
| | | \ \/ /      Prayag Jain | Hax Guru
| |_| |\  /       YouTube: https://youtube.com/c/haxguru
|  _  |/  \       GitHub: https://github.com/Prayag2
|_| |_/_/\_\      Email: prayagjain2@gmail.com

Installing konsave...
Installed successfully! You can now delete this folder.
Try 'konsave -h' for more info!

Dell% konsave -h
zsh: command not found: konsave

`

@t3kg33k
Copy link
Author

t3kg33k commented Mar 5, 2021

Should be fixed in the latest release

Awesome. I will try it out.

Repository owner deleted a comment from t3kg33k Mar 5, 2021
@Prayag2
Copy link
Owner

Prayag2 commented Mar 5, 2021

I'm sorry, I wanted to delete my comment instead and I deleted yours by mistake. I'm soo sorry. But I finally learnt how to deploy it on PyPI and I'll do that ASAP! Thanks for helping me!

@Prayag2
Copy link
Owner

Prayag2 commented Mar 5, 2021

Finally. I've added it to PyPI!! Please delete the old konsave file by running rm ~/.local/bin/konsave to uninstall the old one and run python -m pip install konsave to install it from PyPI! Please let me know if it works for you now! I'm so excited hehe! Thanks for the help!!

@t3kg33k
Copy link
Author

t3kg33k commented Mar 5, 2021

Finally. I've added it to PyPI!! Please delete the old konsave file by running rm ~/.local/bin/konsave to uninstall the old one and run python -m pip install konsave to install it from PyPI! Please let me know if it works for you now! I'm so excited hehe! Thanks for the help!!

Nice work. The warning for the PATH is a good addition.
You can close this issue.

@Prayag2
Copy link
Owner

Prayag2 commented Mar 5, 2021

Thank you :)

@Prayag2 Prayag2 closed this as completed Mar 5, 2021
@kanishkanarch
Copy link
Contributor

kanishkanarch commented Feb 2, 2022

Not working in Arch KDE (installed via pip):

image

@Prayag2
Copy link
Owner

Prayag2 commented Feb 3, 2022

Did you add it to PATH? Try running ~/.local/bin/konsave --help and if that works, then it means that you have not added it to PATH.

@kanishkanarch
Copy link
Contributor

Thanks, added the line export PATH="$HOME/.local/bin:$PATH" at the end of my .bashrc file. Konsave is working now :)

@Prayag2
Copy link
Owner

Prayag2 commented Feb 4, 2022

Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants