Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell Extension Terminal does not work with GH Copilot quick fix "twinkles" #4864

Closed
6 tasks done
StevenBucher98 opened this issue Dec 14, 2023 · 3 comments
Closed
6 tasks done
Assignees
Labels
Area-Extension Terminal Issue-Bug A bug to squash. Needs: Fix Verification Please verify the fix for us!

Comments

@StevenBucher98
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

The GitHub Copilot extension terminal integration does not seem to have the quick fix button when an error occurs on the terminal.

PowerShell Version

PS /Users/stevenbucher/Documents/Testing> $PSVersionTable; $Host

Name                           Value
----                           -----
PSVersion                      7.3.4
PSEdition                      Core
GitCommitId                    7.3.4
OS                             Darwin 23.1.0 Darwin Kernel Version 23…
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Name             : Visual Studio Code Host
Version          : 2023.8.0
InstanceId       : ef4a1084-d50a-47b3-8359-d898d3a6d070
UI               : System.Management.Automation.Internal.Host.Internal
                   HostUserInterface
CurrentCulture   : en-US
CurrentUICulture : en-US
PrivateData      : Microsoft.PowerShell.ConsoleHost+ConsoleColorProxy
DebuggerEnabled  : True
IsRunspacePushed : False
Runspace         : System.Management.Automation.Runspaces.LocalRunspac
                   e

Visual Studio Code Version

1.84.2                              
1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
arm64

Extension Version

ms-vscode.powershell@2023.8.0

Steps to Reproduce

Have any error in the Terminal of VSCode while using the PowerShell Extension terminal.

Visuals

Expected experience in PowerShell Extension terminal:
image

What it actually looks like:
image

Logs

No response

@StevenBucher98 StevenBucher98 added Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed! labels Dec 14, 2023
@JustinGrote
Copy link
Collaborator

This is likely something in how the Shell Integration Github script works that doesn't read or otherwise the PowerShell extension host doesn't provide over a normal pwsh shell.

My guess would be is that it isn't capturing the exit code, as the exit code error also does not show up if you do a simple throw or other error.

@JustinGrote JustinGrote added Feature: VS Code Request to use or implement a VS Code feature. Bug: VS Code Bugs in VS Code itself. and removed Needs: Triage Maintainer attention needed! labels Dec 27, 2023
@JustinGrote
Copy link
Collaborator

JustinGrote commented Dec 30, 2023

Pretty sure this is a dupe of #4854

@andyleejordan andyleejordan added the Resolution-Duplicate Will close automatically. label Jan 3, 2024
@andyleejordan andyleejordan added Area-Extension Terminal and removed Feature: VS Code Request to use or implement a VS Code feature. Bug: VS Code Bugs in VS Code itself. Resolution-Duplicate Will close automatically. labels Jan 3, 2024
@andyleejordan andyleejordan self-assigned this Jan 3, 2024
@andyleejordan andyleejordan moved this to In Progress in Flying Fox Jan 3, 2024
@andyleejordan andyleejordan added the Needs: Fix Verification Please verify the fix for us! label Jan 5, 2024
@andyleejordan
Copy link
Member

Confirmed resolved by @StevenBucher98, thanks!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Flying Fox Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Issue-Bug A bug to squash. Needs: Fix Verification Please verify the fix for us!
Projects
Status: Done
Development

No branches or pull requests

3 participants