Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address tslint issues #1086

Closed
TylerLeonhardt opened this issue Nov 2, 2017 · 5 comments
Closed

address tslint issues #1086

TylerLeonhardt opened this issue Nov 2, 2017 · 5 comments

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Nov 2, 2017 •
edited
Loading

After talking to @TravisEz13, we need to address all tslint issues for compliance.
@TravisEz13
Copy link
Member

tslint not tslist

@TylerLeonhardt TylerLeonhardt changed the title address tslist issues address tslint issues Nov 4, 2017
@rkeithhill
Copy link
Contributor

Um, there are a lot of tslint issues if you go with the tslint:recommended rules.

@TravisEz13
Copy link
Member

@rkeithhill feel free to recommend rules that we should not address. We have a requirement that we run TSLint though.

@rkeithhill
Copy link
Contributor

I've started this work on branch - https://github.com/PowerShell/vscode-powershell/tree/rkeithhill/enable-tslint

@rkeithhill
Copy link
Contributor

rkeithhill commented Jan 23, 2018 •
edited
Loading

I've merged in PR #1148 to address the vast majority of these. There is just one left. I think in this case:

image

I'm just going to suppress the rule on that line of code.

@rkeithhill rkeithhill mentioned this issue Jun 29, 2018
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TylerLeonhardt @rkeithhill @TravisEz13