Add configuration to enable/disable banner #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/session.ts
Outdated
| @@ -179,12 +179,17 @@ export class SessionManager implements Middleware { | |||
| } | |||
| } | |||
|
|
|||
| const startupBanner = this.sessionSettings.integratedConsole.suppressStartupBanner | |||
| ? "" | |||
| : "`n`n =====> PowerShell Integrated Console <=====`n`n"; | |||
There was a problem hiding this comment.
Isn't this the default? We should just let PSES have this string, no?
There was a problem hiding this comment.
I added it to be explicit in case we want to change it in future. On the other hand the duplication isn't ideal and I really don't like needing to write a PowerShell string literal in JS.
Hmmm, ok I'm convinced we should leave it as a the default now.
If we wanted to make it something like ==> VSCode PowerShell Extension <== later, I'd imagine us doing it in the client. But for now I think I agree that leaving it unset in the default case is best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds a configuration option to enable/disable the banner.
Resolves #2370.
Should only be merged after PowerShell/PowerShellEditorServices#1141.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready