Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run pester tests when user cancels questions using the x button (bugfix) #1714

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Jan 22, 2019

PR Summary

@rkeithhill added a dialog in #1701 to ask the user whether he/she wants to run the whole Pester test file when there is an interpolated describe block string. However, when the user does not answer yes or no but cancels via the x button, the answer string will be undefined and the extension will run the test as if the user said yes. Therefore invert the logic to avoid running the test despite the user cancelling
image

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests -> Manually tested the 3 test scenarios
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the title Do not run pester tests when user cancels questions using the x button Do not run pester tests when user cancels questions using the x button (bugfix) Jan 22, 2019
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this @bergmeister

@TylerLeonhardt TylerLeonhardt merged commit f7ae98c into PowerShell:master Jan 22, 2019
@rkeithhill
Copy link
Contributor

For my own edification, I would appreciate being added as a reviewer - lessening the chances that I make the same mistake again. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants