Update broken links in README #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -12,7 +12,7 @@ that Visual Studio Code provides. | |||
| - **Linux** with PowerShell Core (all PowerShell-supported distributions) | |||
| - **macOS and OS X** with PowerShell Core | |||
|
|
|||
| Read the [installation instructions](https://github.com/PowerShell/PowerShell/blob/master/docs/learning-powershell/using-vscode.md) | |||
| Read the [installation instructions](https://docs.microsoft.com/en-us/powershell/scripting/components/vscode/using-vscode?view=powershell-6) | |||
There was a problem hiding this comment.
Suggested change
| Read the [installation instructions](https://docs.microsoft.com/en-us/powershell/scripting/components/vscode/using-vscode?view=powershell-6) | |
| Read the [installation instructions](https://docs.microsoft.com/en-us/powershell/scripting/components/vscode/using-vscode) |
powershell-6 is the default view, so we don't need that part of the url here.
There was a problem hiding this comment.
Ooohhh good pickup – will fix that up! 😄
|
Should be all good now @TylerLeonhardt! Thanks for all your work on the project 👏✨ |
TylerLeonhardt
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The "installation instruction" and "Install from a VSIX" links in the README both pointed to outdated locations, this PR updates those locations as per the corresponding PRs in their repos:
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready