-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to support getting traces from child dsc
processes
#512
Comments
The alternatives that occur to me for passing the trace level to the resource are:
I don't think defining a new |
I did consider the env var route as it seemed the most obvious, but didn't want to introduce a new way to pass info to resources (although |
It seems like we need, at a high level:
I think the latter could be handled by a capability, indicating that the resource participates explicitly in trace messaging. There's several options for the former. One thing that occurs to me if we only pass the value as an |
We can defer the env |
I'm totally on board for deferring, I just think that we need to track/identify the need for passing non-instance-property-data to resources, like trace level and security context, and for those resources to be able to indicate that they support those integrations. I think that's important for resource authors, integrating developers, and users. I can open a separate issue for that, if preferred. |
@michaeltlombardi please open a new issue to generalize an approach for metadata to resources |
Looks like I had already added a |
Summary of the new feature / enhancement
Need to propagate the current tracing level to child resources and accept JSON tracing from child
dsc
resources.DSC currently uses the
tracing
crate JSON format which differs from the simplified format we support for other types of resources.This will greatly improve diagnosability when things fail using things like the
group
resource since currently those traces are hidden.Proposed technical implementation details (optional)
Once #511 is merged, we can set the tracing level as part of the
context
and define a new argKind that passes the tracing level as an argument which thedsc
based resources can accept.We can then have
dsc
accept either thetracing
JSON format in addition to the simplified format, or add an option todsc
to emit JSON traces using the simplified format. The benefit of accepting thetracing
format is that any resources written in Rust can just emit that.The text was updated successfully, but these errors were encountered: