Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell-Adapter should cache resources to disk #371

Closed
SteveL-MSFT opened this issue Mar 26, 2024 · 1 comment
Closed

PowerShell-Adapter should cache resources to disk #371

SteveL-MSFT opened this issue Mar 26, 2024 · 1 comment
Labels
Issue-Enhancement The issue is a feature or idea
Milestone

Comments

@SteveL-MSFT
Copy link
Member

Summary of the new feature / enhancement

PowerShell-Adapter should cache the discovered resources to disk so it doesn't have to perform a full discovery each time which is the main perf bottleneck.

Proposed technical implementation details (optional)

Probably just save the cache as a JSON file somewhere under the user data path:

  • Keep last modified date of segments of PSModulePath and modules so if any change, it can just do discovery for those segments rather than full
  • If PSModulePath changes from last discovery, may be better to rebuilt cache rather than trying to discover new parts and throw away old ones
  • Keep only relevant info which is likely the module that contains the PS resources. Not sure if there is big perf or functional impact to cache the resources themselves in addition to the module.
@SteveL-MSFT SteveL-MSFT added the Issue-Enhancement The issue is a feature or idea label Mar 26, 2024
@SteveL-MSFT SteveL-MSFT added this to the 3.0-RC milestone Apr 3, 2024
@anmenaga
Copy link
Contributor

Fixed in #432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement The issue is a feature or idea
Projects
None yet
Development

No branches or pull requests

2 participants