Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a time column in the column configurator can eventually duplicate the time column #8861

Closed
3 tasks done
pauldambra opened this issue Mar 4, 2022 · 1 comment
Closed
3 tasks done
Labels
bug Something isn't working right feature/activity Feature Tag: Activity (fka Events) P2 Semi-urgent, non-breaking, affects UX but functional

Comments

@pauldambra
Copy link
Member

Bug description

2022-03-04 12 17 42

The events table adds a time column even if one isn't set in the column configurator

Setting a time column (if a time property is available on events.) initially behaves correctly but on repeated save will duplicate the time column

Expected behavior

you don't get two time columns

How to reproduce

  1. use column configurator to add a time column
  2. navigate to another tab
  3. come back to the events page
  4. the table will display correctly
  5. open the column configurator
  6. it will include the time column added previously
  7. click save
  8. two time columns

Environment

  • PostHog Cloud
  • self-hosted PostHog (ClickHouse-based), version/commit: please provide
  • self-hosted PostHog (Postgres-based, legacy), version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!

@pauldambra pauldambra added bug Something isn't working right feature/activity Feature Tag: Activity (fka Events) quality labels Mar 4, 2022
@pauldambra pauldambra added the P2 Semi-urgent, non-breaking, affects UX but functional label Mar 17, 2022
@pauldambra
Copy link
Member Author

choose $time for a column in the configurator

both the tableConfigLogic and columnConfiguratorLogic show $time as one of the selected columns.

Navigate away and then back. The columns are back to default in the view

the tableConfigLogic shows 'DEFAULTas the selected columns. ThecolumnConfiguratorLogicshowstime` as one of the selected columns.

time is the key for the timestamp column so its value is duplicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/activity Feature Tag: Activity (fka Events) P2 Semi-urgent, non-breaking, affects UX but functional
Projects
None yet
Development

No branches or pull requests

2 participants