Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL - DROP posthog_event table #8539

Closed
guidoiaquinti opened this issue Feb 10, 2022 · 6 comments
Closed

PostgreSQL - DROP posthog_event table #8539

guidoiaquinti opened this issue Feb 10, 2022 · 6 comments
Labels
enhancement New feature or request stale

Comments

@guidoiaquinti
Copy link
Contributor

Is your feature request related to a problem?

As we don't host events into PostgreSQL anymore, we should:

  1. cleanup all the code still referencing the table
  2. drop the table

Describe the solution you'd like

See above

Describe alternatives you've considered

Do nothing

Additional context

See internal Slack conversation.

@guidoiaquinti guidoiaquinti added the enhancement New feature or request label Feb 10, 2022
@sreeo
Copy link

sreeo commented Feb 17, 2022

Can I pick this up?

@guidoiaquinti
Copy link
Contributor Author

👋 Hey @sreeo, thank you for volunteering but I think @macobo is already working on it. See:

@macobo macobo self-assigned this Feb 17, 2022
@macobo
Copy link
Contributor

macobo commented Feb 17, 2022

Took a few PRs but the posthog_events table is no longer being read in any of our code.

PRs:

We still have the model in codebase (as it's referenced via some other tables) and haven't dropped the actual table. I think this is good enough for now and we can TRUNCATE this in production.

I'd avoid adding a migration to drop/truncate to avoid potential pain with postgres-users accidentally updating at some future date.

@guidoiaquinti
Copy link
Contributor Author

Nice work 👏 Let's keep this issue open till we actually drop the table.

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

4 participants