-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library version into headers of integrations #852
Comments
@mariusandra do we still want to do this? |
@paolodamico work is ongoing but somehow stalled for the JS integration: PostHog/posthog-js#351 We should do this for others as well, once we decide on a safe header to put this information in. |
In that PR I've proposed I don't think we need to split them because if the body can be processed we will still receive lib and version from it |
The solution we ended up with in #351 was to add a But that's pretty passive and we should tag the version in the sentry scope |
For feature flag definitions, all server-side libraries send the I think we can re-use this for I quite like the idea of sentry tags as well, for a bit deeper analytics, but this needs to happen only in one place: the servers where we capture exceptions, so no new library bloat there. |
I should trust myself more :) If compression fails we grab the |
So, the task here becomes
Knowing that and with #11301 we can assert whether this is complete and whether they will be tagged in Sentry 👀 |
very brief pass over the libraries... -> not all of them send library version
|
@pauldambra do you remember why we don't need for react-native? its definitely as native as android and ios, so it should I guess. |
blast from the past 🤣 the "doesn't need" column I think is about the double compression that the web SDK does. So I bet I meant that the body is available without the decompression step you have to add for the web SDK. But I completely don't remember. Totally fine to over-rule me if it doesn't make sense 😊 |
Is your feature request related to a problem? Please describe.
There's an error in sentry that's sent to the
/e
endpoint, which doesn't contain any request data. I'd like to know what integration causes it, but details about that should be in the data that's missing.Describe the solution you'd like
I'd like the
$lib
and$lib_version
properties to be in the headers as well. Doing so can greatly help pinpoint issues.Describe alternatives you've considered
Guessing based on other data or patterns, flipping a coin.
The text was updated successfully, but these errors were encountered: