Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature flags model [UX] #1807

Closed
6 tasks
paolodamico opened this issue Oct 4, 2020 · 6 comments · Fixed by #3675
Closed
6 tasks

Improve feature flags model [UX] #1807

paolodamico opened this issue Oct 4, 2020 · 6 comments · Fixed by #3675
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@paolodamico
Copy link
Contributor

Details

Currently, the feature flags model have a name and key attributes (see screenshot below), however based on how the keys are used (e.g. billing-page, alt-subscription-button) it'd be more intuitive to use the key more as a name, and the name as a description (allowing for more details).

image

We can therefore do the following improvements:

  • Change name to description (can be implemented only as a change on the UI, no need to change the entire model).
  • Description should now no longer be required.
  • Invert order of name & key (in columns and form).
  • Convert the description text field to a multi-line text field.
  • Add placeholder information to the inputs (e.g. new-signup-page & "When on, the redesigned sign up page will be shown")
  • Add an info icon next to the key title (see image below) with a tooltip containing more information explaining what they key is, the format, and particularly mention the consequences of changing it.

@paolodamico paolodamico added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 4, 2020
@siddharajmane
Copy link

siddharajmane commented Oct 4, 2020

Hi, can you assign me this!! I am willing to contribute.

@Twixes
Copy link
Member

Twixes commented Oct 4, 2020

Sure, this is yours @siddhu890

@siddharajmane
Copy link

Hey, can you help me where the template resides on the project repository?

@Twixes
Copy link
Member

Twixes commented Oct 5, 2020

It's FeatureFlags.js.

@timgl
Copy link
Collaborator

timgl commented Oct 20, 2020

@siddhu890 Any progress on this so far?

@paolodamico
Copy link
Contributor Author

Adding to this. It isn't clear that you don't need to specify a roll-out percentage (i.e. 100% roll-out = not checking the roll-out box). We need better language and UX here (e.g. "Would you like to roll-out this flag only to a percentage of users?")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants