-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor request logic #1055
Conversation
# Conflicts: # src/posthog-core.ts # src/posthog-featureflags.ts
Size Change: -13.5 kB (-2%) Total Size: 849 kB
|
Co-authored-by: Paul D'Ambra <paul@posthog.com>
… into feat/request-refactor
# Conflicts: # src/posthog-core.ts # src/posthog-featureflags.ts # src/types.ts
@@ -65,7 +63,8 @@ export interface AutocaptureConfig { | |||
|
|||
export interface PostHogConfig { | |||
api_host: string | |||
api_method: string | |||
/** @deprecated - This property is no longer supported */ | |||
api_method?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This never made sense as different requests require different methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran locally, all seems to work 👍 - great job!
Changes
Our code paths around making api requests is messy to say the least. Makes it hard to reason on, hard to make changes and includes a lot of spaghetti code that inflates the bundle size.
request
needs to know about the internals of it nowChecklist