Only add when opt_out_useragent_filter=true

PostHog · Jan 5, 2024 · de5c37d · de5c37d
1 parent 3622c39
commit de5c37d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/__tests__/posthog-core.js b/src/__tests__/posthog-core.js
@@ -369,7 +369,6 @@ describe('posthog core', () => {
 
         it('returns calculated properties', () => {
             expect(given.subject).toEqual({
-                $browser_type: 'browser',
                 token: 'testtoken',
                 event: 'prop',
                 $lib: 'web',
@@ -384,7 +383,6 @@ describe('posthog core', () => {
             given('property_blacklist', () => ['$lib', 'persistent'])
 
             expect(given.subject).toEqual({
-                $browser_type: 'browser',
                 token: 'testtoken',
                 event: 'prop',
                 distinct_id: 'abc',

diff --git a/src/posthog-core.ts b/src/posthog-core.ts
@@ -994,7 +994,7 @@ export class PostHog {
             properties['$duration'] = parseFloat((duration_in_ms / 1000).toFixed(3))
         }
 
-        if (userAgent) {
+        if (userAgent && this.config.opt_out_useragent_filter) {
             properties['$browser_type'] = _isBlockedUA(userAgent, this.config.custom_blocked_useragents)
                 ? 'bot'
                 : 'browser'