New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client SDKs should cache feature flags #39

Closed

marandaneto opened this issue Oct 5, 2023 · 0 comments · Fixed by #61

Labels

enhancement Feature Flags

Member

marandaneto commented Oct 5, 2023 •

edited

Loading

Description

When the decide API is called, update the values of the feature flags in the disk
Always read the cached feature flags if the decide API has not finished yet, e.g. during SDK init.
Consider maintaining a mirror of the feature flags in memory to avoid all the IO of reading flags every time (the caching and reading should be synchronized though.)

https://github.com/PostHog/posthog-js-lite/blob/4a707fdc660785c187e0bfd99ec2df1887afcf5c/posthog-core/src/index.ts#L955-L963

Worth noting that the Android SDK v2 also didn't cache the feature flags: just in memory.

marandaneto added Feature Flags enhancement labels

marandaneto mentioned this issue

Cache and read feature flags on the disk #61

Merged

4 tasks

marandaneto closed this as completed in #61

marandaneto mentioned this issue

recording: OnTouchEventListener try catch guard to swallow unexpected errors #147

Merged

4 tasks

marandaneto mentioned this issue

recording: capture touch interaction off of main thread to avoid ANRs #165

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment