Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major upgrades need to follow upgrade-notes #90

Closed
tiina303 opened this issue Aug 4, 2021 · 5 comments · Fixed by PostHog/posthog.com#2262
Closed

Major upgrades need to follow upgrade-notes #90

tiina303 opened this issue Aug 4, 2021 · 5 comments · Fixed by PostHog/posthog.com#2262
Assignees
Labels
enhancement New feature or request P1 Urgent, non-breaking

Comments

@tiina303
Copy link
Contributor

tiina303 commented Aug 4, 2021

Creating an issue as docs are moving to posthog.com, so I don't want to change it twice.

Add some bigger bolder signs around how users should verify that they are doing a major upgrade or not (ideally a single shell cmd) & if so direct them to upgrade notes

helm list

shows the chart version
we can check the tags to see where the chart is at https://github.com/PostHog/charts-clickhouse/tags

@tiina303 tiina303 added the enhancement New feature or request label Aug 4, 2021
@tiina303 tiina303 self-assigned this Aug 4, 2021
@tiina303
Copy link
Contributor Author

tiina303 commented Aug 5, 2021

Related to docs: make email & sentry setup more high profile

@macobo
Copy link
Contributor

macobo commented Aug 5, 2021

Related: We're using github releases but they don't currently contain any information on the release. That would be a good place to communicate these issues as well.

See also helm/chart-releaser#118

@tiina303
Copy link
Contributor Author

Idea: we can make helm fail major upgrades preemptively (similarly to the right file used verification) if they don't provide a value majorUpgrade=true e.g. --set majorUpgrade=true at the end of the upgrade command & link folks to the upgrade notes

@tiina303
Copy link
Contributor Author

@guidoiaquinti related to you working on the chart, what do you think of the idea above & would you want to add that to the list of chart improvements you're working on this sprint?

@guidoiaquinti
Copy link
Contributor

Unfortunately I don't think I'll have time this sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Urgent, non-breaking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants