Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "repeat" option to "sigh test". #779

Closed
shaper opened this issue Feb 21, 2018 · 6 comments
Closed

Add "repeat" option to "sigh test". #779

shaper opened this issue Feb 21, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@shaper
Copy link
Contributor

shaper commented Feb 21, 2018

Have to emulate currently, with unnecessary overhead for each run and no built-in summary of pass/fail, via something like:

'for i in `seq 10`; do ./tools/sigh test --grep='demo'; done'

@mmandlis @dstockwell

@shaper shaper added this to the Bounties milestone Feb 21, 2018
@shaper shaper self-assigned this Feb 21, 2018
@shaper shaper removed their assignment Nov 28, 2018
@lindner
Copy link
Contributor

lindner commented Jan 11, 2019

Potential steps:

  • Add a new command line option to sigh.js
  • Find the magic mocha repeat or numtimes api.

@shaper
Copy link
Contributor Author

shaper commented Jan 11, 2019

@mykmartin I recall you'd found a way to use the mocha repeat through double-double-hyphens or something but I can't find it now.

@mykmartin
Copy link
Contributor

@shaper Not that I can recall... webdriver has the mochaOpts flag, so you can do this sort of thing: npm run test-wdio -- --mochaOpts.grep 'gl.*'

But that's not applicable to the standard command-line tests run by sigh.

@thebrianchen
Copy link

thebrianchen commented Jan 14, 2019

Is the ultimate goal to optionally retry tests 'n' times until it passes, or to run tests repeatedly to determine flakiness/test latency?

@shaper
Copy link
Contributor Author

shaper commented Jan 25, 2019

My intent was the latter: "run tests repeatedly to determine flakiness/test latency". We do need a summary of output, I see that's been mentioned on the PR. Since otherwise we can basically effect with the shell command at the start of this issue.

@lindner
Copy link
Contributor

lindner commented May 23, 2019

I think we can mark this done. You can run a large number of tests to determine flakiness and you get a summary of output. Thanks so much @thebrianchen

@lindner lindner closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants